Only run legacy-native-module in Release#51494
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75139882 |
Summary: A recent diff introduced the legacy-native-module.yml E2E test for maestro. The test is consistently failing in CI in Debug mode, because it requires to navigate to the APIs tab. However, the navigation to that tab is not working in debug mode because there is a logbox on top of the tabbar that prevents the tests to tap on the button. The test works fine in Release mode because we don't have logboxes there. As a temporary solution to unblock CI while we fix the warnings that prevent the navigation, we are disabling the test for running in debug mode. This will not reduce the coverage as: - the test still runs in Release mode - the debug tests have been added to verify the connection with metro, which is checked by the other tests in the test suite. ## Changelog: [Internal] - Differential Revision: D75139882
cipolleschi
force-pushed
the
export-D75139882
branch
from
631f71d to
5972bb1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75139882 |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
removed
the
Stale
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A recent diff introduced the legacy-native-module.yml E2E test for maestro.
The test is consistently failing in CI in Debug mode, because it requires to navigate to the APIs tab. However, the navigation to that tab is not working in debug mode because there is a logbox on top of the tabbar that prevents the tests to tap on the button.
The test works fine in Release mode because we don't have logboxes there.
As a temporary solution to unblock CI while we fix the warnings that prevent the navigation, we are disabling the test for running in debug mode.
This will not reduce the coverage as:
Changelog:
[Internal] -
Differential Revision: D75139882