Add trace helper to Systrace (#56936)#56936
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106071568. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 22, 2026
Summary:
Adds a new `trace` helper to the `Systrace` module that wraps a function call between `beginEvent` and `endEvent`, ensuring the trace section is closed even if the function throws.
Usage:
```
Systrace.trace('name', () => {
// logic to trace
});
```
The implementation is guarded with `isEnabled()` and inlines `beginEvent`/`endEvent` so that the no-op path avoids redundant work when tracing is disabled.
Changelog:
[General][Added] - Add `Systrace.trace` helper that wraps a function with begin/end events using try/finally
Reviewed By: javache
Differential Revision: D106071568
meta-codesync
Bot
changed the title
trace helper to Systracetrace helper to Systrace (#56936)
rubennorte
force-pushed
the
export-D106071568
branch
from
c892b41 to
c8bab1f
Compare
Summary:
Adds a new `trace` helper to the `Systrace` module that wraps a function call between `beginEvent` and `endEvent`, ensuring the trace section is closed even if the function throws.
Usage:
```
Systrace.trace('name', () => {
// logic to trace
});
```
The implementation is guarded with `isEnabled()` and inlines `beginEvent`/`endEvent` so that the no-op path avoids redundant work when tracing is disabled.
Changelog:
[General][Added] - Add `Systrace.trace` helper that wraps a function with begin/end events using try/finally
Reviewed By: javache
Differential Revision: D106071568
rubennorte
force-pushed
the
export-D106071568
branch
from
c8bab1f to
ba788c2
Compare
Collaborator
|
This pull request was successfully merged by @rubennorte in e6c7a26 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in e6c7a26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a new
tracehelper to theSystracemodule that wraps a function call betweenbeginEventandendEvent, ensuring the trace section is closed even if the function throws.Usage:
The implementation is guarded with
isEnabled()and inlinesbeginEvent/endEventso that the no-op path avoids redundant work when tracing is disabled.Changelog:
[General][Added] - Add
Systrace.tracehelper that wraps a function with begin/end events using try/finallyReviewed By: javache
Differential Revision: D106071568