Skip to content

Conversation

@vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Dec 4, 2025

Summary:
Changelog: [Internal]

The correct value is validateStream and not validStream

https://nodejs.org/api/util.html#utilstyletextformat-text-options

Reviewed By: huntie

Differential Revision: D88368928

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 4, 2025

@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88368928.

…g event on if this changes (facebook#54447)

Summary:

Changelog: [Internal]

Expose `unstable_hasConnectedDevices` and `unstable_addHasConnectedDevicesListener` from both `InspectorProxy` and `DevMiddleware` that tells the user if any devices are connected to `devMiddleware` and allows to listen to whenever this state changes.

Reviewed By: motiz88

Differential Revision: D86319965
…ODE (facebook#54654)

Summary:

make the default debugger-shell spawn command unset ELECTRON_RUN_AS_NODE

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D86673603
…ook#54528)

Summary:

Changelog: [Internal]

Currently, `DefaultBrowserLauncher.js` holds arguments configuring how the debugger shell is launched. Instead, move some of them downstream, and make `DefaultBrowserLauncher.js` use the defaults.

Reviewed By: motiz88

Differential Revision: D86772692
Summary:

Changelog: [Internal]

The correct value is `validateStream` and not `validStream`

https://nodejs.org/api/util.html#utilstyletextformat-text-options

Reviewed By: huntie

Differential Revision: D88368928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants