fix: RNGP using node invocation non-compatible with Gradle Compilation Cache #54801
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D88492310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Invoking
Runtime.getRuntime().exec()is not compatible with Gradle Configuration Cache and providers should be used instead.This error hasn't surfaced yet due to fact that this branch of code is rarely hit as the users usually provide correct path to the CLI in their
app/build.gradlefile. I stumbled upon it accidentally when bumping RN in monorepo and the CLI path was no longer valid.Changelog:
[ANDROID] [FIXED] - RNGP using node invocation non-compatible with Gradle Compilation Cache
Test Plan:
I tested it in a rnc-cli app, where I provided an invalid path for
cliFile- the error was fixed after applying this patch.