Align default transform profile Babel preset with legacy Hermes - drop "older" engines #54806
+35
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p "older" engines Summary: Align the default transform profile in our Babel preset with the current state of `hermes-stable`, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal. This will allow us to subsequently repurpose transform profiles (`unstable_transformProfile`) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows: - `hermes-canary` -> Hermes v1 (experimental features) - `hermes-stable` -> Hermes v1 - Default -> All supported engines (i.e, Hermes v1 and legacy) Changelog: [General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines Reviewed By: huntie Differential Revision: D88269506
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Align the default transform profile in our Babel preset with the current state of
hermes-stable, drop non-Hermes, pre-ES6 engines which have been unsupported in core since the JSC removal.This will allow us to subsequently repurpose transform profiles (
unstable_transformProfile) to remove transforms unnecessary for Hermes v1 (aka Static Hermes) as follows:hermes-canary-> Hermes v1 (experimental features)hermes-stable-> Hermes v1Changelog:
[General][Removed] Remove Babel preset transforms for already-unsupported non-Hermes engines
Reviewed By: huntie
Differential Revision: D88269506