[BUG] Slackbot notifier false positive notification

[etagwerker]

Expected Behavior

When I log a time entry like this one:

Worked on PROJECT-1235: Solved bug and submitted PR

I should not get a notification from the Slackbot.

Actual Behavior

When I log a time entry like this one:

Worked on PROJECT-1235: Solved bug and submitted PR

I get a notification from the Slackbot.

Possible Fix

Improve the regular expression. The : is throwing things off.

To Reproduce

1. Log an entry with PROJECT-123: in Noko
2. Get a notification around 8pm

Additional Information

Here is more info:

• pecas/app/domain/time_entry/description_rules.rb

  Lines 18 to 24 in b8891ad

  	def has_word_count?
  	if has_jira_ticket?
  	@description.split.size > 1
  	else
  	@description.split.size > 0
  	end
  	end

• pecas/app/domain/time_entry/description_rules.rb

  Line 2 in b8891ad

  JIRA_REGEX = /(?:\s|^)([A-Z]+-[0-9]+)(?=\s|$)/

I will abide by the code of conduct

[arielj]

Could be useful to also check this line doing a gsub before matching the Jira ID:

pecas/app/domain/time_entry/description_rules.rb

Line 42 in b8891ad

@description.gsub(/[\[\]\,\.]/, ' ').scan(JIRA_REGEX).any?

Because will have a similar issue doing something like Woking on something (PROJ-123) since the ( ) will also make it fail.

Not sure what's better, if an update of the gsub regular expression removing chars or if an update on the JIRA regular expression to ignore unwanted chars.

[aisayo]

I agree that updating the gsub to removing chars will be more beneficial.