Distribution is broken

[ivorbosloper]

I tried to use fiboa-cli==0.11.0 or fiboa-cli==0.10.0, but we seem to miss subdirectories in the distrubution?

Steps to reproduce:

$ mkvirtualenv fiboa011
$ pip install fiboa-cli==0.11.0
$ fiboa convert be_vlg -o test.parquet

fiboa CLI 0.11.0 - Convert 'be_vlg'

Converter for 'be_vlg' not available or faulty: No module named 'fiboa_cli.datasets.commons'

There is no commons directory in the <env>/lib/python3.13/site-packages/fiboa_cli/datasets/

[m-mohr]

Hmm, can you test the latest 0.20.x version? 0.1x.x is tge old version for fiboa 0.2

[ivorbosloper]

I was actually trying to generate fiboa-0.2 test-files for the migrate command 😄 . I can make it work by doing pip install -e . with an old git version, but this is a serious problem for users:

$ mkvirtualenv fiboa020
$ pip install fiboa-cli==0.20.0
$ fiboa convert be_vlg -o test.parquet

ModuleNotFoundError: No module named 'fiboa_cli.datasets'

There is no datasets directory in env/fiboa020/lib/python3.13/site-packages/fiboa_cli . Somehow, we have to recursively add the subdirectories during packaging?

[ivorbosloper]

You can see it at pypi: https://pypi.org/project/fiboa-cli/0.20.0/#files , there are files missing in the distribution:

$ wget https://files.pythonhosted.org/packages/c3/5e/a4fca243176f312506a831f610b211482faeb7d0aa8d85284ed51599861c/fiboa_cli-0.20.0.tar.gz
$ tar xvzf fiboa_cli-0.20.0.tar.gz 
x fiboa_cli-0.20.0/
x fiboa_cli-0.20.0/LICENSE
x fiboa_cli-0.20.0/PKG-INFO
x fiboa_cli-0.20.0/README.md
x fiboa_cli-0.20.0/fiboa_cli/
x fiboa_cli-0.20.0/fiboa_cli/__init__.py
x fiboa_cli-0.20.0/fiboa_cli/cli/
x fiboa_cli-0.20.0/fiboa_cli/cli/__init__.py
x fiboa_cli-0.20.0/fiboa_cli/cli/setup.py
x fiboa_cli-0.20.0/fiboa_cli/describe.py
x fiboa_cli-0.20.0/fiboa_cli/fiboa/
x fiboa_cli-0.20.0/fiboa_cli/fiboa/version.py
x fiboa_cli-0.20.0/fiboa_cli/registry.py
x fiboa_cli-0.20.0/fiboa_cli/rename_extension.py
x fiboa_cli-0.20.0/fiboa_cli.egg-info/
x fiboa_cli-0.20.0/fiboa_cli.egg-info/PKG-INFO
x fiboa_cli-0.20.0/fiboa_cli.egg-info/SOURCES.txt
x fiboa_cli-0.20.0/fiboa_cli.egg-info/dependency_links.txt
x fiboa_cli-0.20.0/fiboa_cli.egg-info/entry_points.txt
x fiboa_cli-0.20.0/fiboa_cli.egg-info/requires.txt
x fiboa_cli-0.20.0/fiboa_cli.egg-info/top_level.txt
x fiboa_cli-0.20.0/pyproject.toml
x fiboa_cli-0.20.0/setup.cfg
$

[m-mohr]

Oh no, wondering when this started. Seems we need to change how we identify files for the build...

[ivorbosloper]

Ah, but it works for 0.20.3 . So you fixed it somehow

[ivorbosloper]

It was fixed between 0.20.0 and 0.20.1 ... You get an indication quickly when looking at file-sizes:

11kb vs 67kb

https://pypi.org/project/fiboa-cli/0.20.0/#files https://pypi.org/project/fiboa-cli/0.20.1/#files

[ivorbosloper]

Next release, we should just test it...

[m-mohr]

Oh, interesting. I'll check

[m-mohr]

I think in 0.20.0 we didn't had any converters yet in the codebase, thus the file size change. I couldn't find any relevant changes to the pyproject.toml, so I think it works for all of 0.20.0. Why it was broken in 0.1x.x is a bit odd, because it worked before, but maybe also not that important anymore? Should we close this?