Skip to content

Melhorias #1

@dario-bandeira

Description

@dario-bandeira

Algumas sugestões de melhorias.

Esse trecho...

# Check if the snake has hit itself
    for i in range(1, len(snake) - 1):
        if snake[0][0] == snake[i][0] and snake[0][1] == snake[i][1]:
            game_over = True
            break

...poderia ser substituído por esse:

# Check if the snake has hit itself
    if snake[0] in snake[1:]:
        game_over = True
        break

E esse...

for i in range(len(snake) - 1, 0, -1):
        snake[i] = (snake[i-1][0], snake[i-1][1])
        
    # Actually make the snake move.
    if my_direction == UP:
        snake[0] = (snake[0][0], snake[0][1] - 10)
    if my_direction == DOWN:
        snake[0] = (snake[0][0], snake[0][1] + 10)
    if my_direction == RIGHT:
        snake[0] = (snake[0][0] + 10, snake[0][1])
    if my_direction == LEFT:
        snake[0] = (snake[0][0] - 10, snake[0][1])

...poderia ser substituído por esse:

snake.pop()

        # Actually make the snake move.
        if my_direction == UP:
            snake.insert(0, (snake[0][0], snake[0][1] - 10))
        if my_direction == DOWN:
            snake.insert(0, (snake[0][0], snake[0][1] + 10))
        if my_direction == RIGHT:
            snake.insert(0, (snake[0][0] + 10, snake[0][1]))
        if my_direction == LEFT:
            snake.insert(0, (snake[0][0] - 10, snake[0][1]))

Não sei se melhora o desempenho, mas o código fica levemente mais enxuto.
Um abraço!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions