From 9194d6d67323d0282d8ab69061210d1236b7e7a8 Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Wed, 4 Feb 2026 15:06:16 +0000 Subject: [PATCH 1/3] refactor(angular): improve type safety in injectTranslation function --- packages/angular/src/lib/provider.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/angular/src/lib/provider.ts b/packages/angular/src/lib/provider.ts index 7363fe3c..69ce4b10 100644 --- a/packages/angular/src/lib/provider.ts +++ b/packages/angular/src/lib/provider.ts @@ -49,6 +49,7 @@ import { getBehavior, type CountryData, } from "@firebase-oss/ui-core"; +import type { TranslationCategory, TranslationKey } from "@firebase-oss/ui-translations"; const FIREBASE_UI_STORE = new InjectionToken("firebaseui.store"); const FIREBASE_UI_POLICIES = new InjectionToken("firebaseui.policies"); @@ -185,9 +186,12 @@ export function injectRecaptchaVerifier(element: () => ElementRef( + category: T, + key: TranslationKey +) { const ui = injectUI(); - return computed(() => getTranslation(ui(), category as any, key as any)); + return computed(() => getTranslation(ui(), category, key)); } /** From 5859a553af72dd583b436e1fc116a67bfcc41d0e Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Wed, 4 Feb 2026 15:10:32 +0000 Subject: [PATCH 2/3] fix: export types --- packages/angular/src/lib/provider.ts | 3 ++- packages/core/src/translations.ts | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/angular/src/lib/provider.ts b/packages/angular/src/lib/provider.ts index 69ce4b10..1651f3eb 100644 --- a/packages/angular/src/lib/provider.ts +++ b/packages/angular/src/lib/provider.ts @@ -48,8 +48,9 @@ import { getTranslation, getBehavior, type CountryData, + type TranslationCategory, + type TranslationKey, } from "@firebase-oss/ui-core"; -import type { TranslationCategory, TranslationKey } from "@firebase-oss/ui-translations"; const FIREBASE_UI_STORE = new InjectionToken("firebaseui.store"); const FIREBASE_UI_POLICIES = new InjectionToken("firebaseui.policies"); diff --git a/packages/core/src/translations.ts b/packages/core/src/translations.ts index 0bf63ece..5743afe4 100644 --- a/packages/core/src/translations.ts +++ b/packages/core/src/translations.ts @@ -21,6 +21,9 @@ import { } from "@firebase-oss/ui-translations"; import { type FirebaseUI } from "./config"; +// Re-export types for use in other packages +export type { TranslationCategory, TranslationKey }; + /** * Gets a translated string for a given category and key. * From ad9ca4f29b5c454445bcdfe1bd983f2831c3d221 Mon Sep 17 00:00:00 2001 From: MichaelVerdon Date: Wed, 4 Feb 2026 15:12:30 +0000 Subject: [PATCH 3/3] chore: run format --- packages/angular/src/lib/provider.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/angular/src/lib/provider.ts b/packages/angular/src/lib/provider.ts index 1651f3eb..8a208b95 100644 --- a/packages/angular/src/lib/provider.ts +++ b/packages/angular/src/lib/provider.ts @@ -187,10 +187,7 @@ export function injectRecaptchaVerifier(element: () => ElementRef( - category: T, - key: TranslationKey -) { +export function injectTranslation(category: T, key: TranslationKey) { const ui = injectUI(); return computed(() => getTranslation(ui(), category, key)); }