Skip to content

refactor(angular): improve type safety in injectTranslation function #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelVerdon wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Open

refactor(angular): improve type safety in injectTranslation function #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9194d6d
refactor(angular): improve type safety in injectTranslation function
MichaelVerdon Feb 4, 2026
5859a55
fix: export types
MichaelVerdon Feb 4, 2026
ad9ca4f
chore: run format
MichaelVerdon Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/angular/src/lib/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ import {
getTranslation,
getBehavior,
type CountryData,
type TranslationCategory,
type TranslationKey,
} from "@firebase-oss/ui-core";

const FIREBASE_UI_STORE = new InjectionToken<FirebaseUIStore>("firebaseui.store");
Expand Down Expand Up @@ -185,9 +187,9 @@ export function injectRecaptchaVerifier(element: () => ElementRef<HTMLDivElement
* @param key - The translation key within the category.
* @returns A computed signal containing the translated string.
*/
export function injectTranslation(category: string, key: string) {
export function injectTranslation<T extends TranslationCategory>(category: T, key: TranslationKey<T>) {
const ui = injectUI();
return computed(() => getTranslation(ui(), category as any, key as any));
return computed(() => getTranslation(ui(), category, key));
}

/**
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import {
} from "@firebase-oss/ui-translations";
import { type FirebaseUI } from "./config";

// Re-export types for use in other packages
export type { TranslationCategory, TranslationKey };

/**
* Gets a translated string for a given category and key.
*
Expand Down