From 0100ed4254d6914a2619cec8ce447ea4da98bcb9 Mon Sep 17 00:00:00 2001
From: Truong Hua <truong.hua@youthdev.net>
Date: Sat, 14 Aug 2021 20:52:20 +0700
Subject: [PATCH] Fix bug metrics does not respect threshold config

This commit fix the bug that even $metric->threshold is configured to a greater than 1 minute, but the metrics generated was always filled with default value to the returned metric points for every minute.
---
 app/Repositories/Metric/MetricRepository.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/Repositories/Metric/MetricRepository.php b/app/Repositories/Metric/MetricRepository.php
index c424336b19cd..533b5fe506f3 100644
--- a/app/Repositories/Metric/MetricRepository.php
+++ b/app/Repositories/Metric/MetricRepository.php
@@ -71,7 +71,7 @@ public function listPointsLastHour(Metric $metric)
 
         for ($i = 0; $i < $timeframe; $i++) {
             if (!$points->has($pointKey)) {
-                if ($i >= $metric->threshold) {
+                if ($minutesWithNoData >= $metric->threshold) {
                     $points->put($pointKey, $metric->default_value);
                     //We put default value as metric, so we can reset counter for minutes without data
                     $minutesWithNoData = 0;