[feat] idempotent kubernetes hooks enabling

Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>

Author: ipaqsa

pkg/hook/controller/hook_controller.go

@@ -265,6 +265,20 @@ func (hc *HookController) UpdateMonitor(monitorId string, kind, apiVersion strin
 	return nil
 }
 
+func (hc *HookController) EnableKubernetesBindings() ([]BindingExecutionInfo, error) {
+	if hc.KubernetesController != nil {
+		return hc.KubernetesController.EnableKubernetesBindings()
+	}
+
+	return nil, nil
+}
+
+func (hc *HookController) DisableKubernetesBindings() {
+	if hc.KubernetesController != nil {
+		hc.KubernetesController.DisableKubernetesBindings()
+	}
+}
+
 func (hc *HookController) EnableScheduleBindings() {
 	if hc.ScheduleController != nil {
 		hc.ScheduleController.EnableScheduleBindings()

pkg/hook/controller/kubernetes_bindings_controller.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/deckhouse/deckhouse/pkg/log"
 
-	pkg "github.com/flant/shell-operator/pkg"
+	"github.com/flant/shell-operator/pkg"
 	bctx "github.com/flant/shell-operator/pkg/hook/binding_context"
 	htypes "github.com/flant/shell-operator/pkg/hook/types"
 	kubeeventsmanager "github.com/flant/shell-operator/pkg/kube_events_manager"
@@ -27,6 +27,7 @@ type KubernetesBindingsController interface {
 	WithKubernetesBindings([]htypes.OnKubernetesEventConfig)
 	WithKubeEventsManager(kubeeventsmanager.KubeEventsSource)
 	EnableKubernetesBindings() ([]BindingExecutionInfo, error)
+	DisableKubernetesBindings()
 	UpdateMonitor(monitorId string, kind, apiVersion string) error
 	UnlockEvents()
 	UnlockEventsFor(monitorID string)
@@ -82,6 +83,12 @@ func (c *kubernetesBindingsController) WithKubeEventsManager(kubeEventsManager k
 func (c *kubernetesBindingsController) EnableKubernetesBindings() ([]BindingExecutionInfo, error) {
 	res := make([]BindingExecutionInfo, 0)
 
+	c.l.Lock()
+	if len(c.BindingMonitorLinks) > 0 {
+		return res, nil
+	}
+	c.l.Unlock()
+
 	for _, config := range c.KubernetesBindings {
 		err := c.kubeEventsManager.AddMonitor(config.Monitor)
 		if err != nil {
@@ -182,6 +189,16 @@ func (c *kubernetesBindingsController) StopMonitors() {
 	})
 }
 
+func (c *kubernetesBindingsController) DisableKubernetesBindings() {
+	c.l.Lock()
+	defer c.l.Unlock()
+
+	for _, binding := range c.BindingMonitorLinks {
+		_ = c.kubeEventsManager.StopMonitor(binding.MonitorId)
+		delete(c.BindingMonitorLinks, binding.MonitorId)
+	}
+}
+
 func (c *kubernetesBindingsController) CanHandleEvent(kubeEvent kemtypes.KubeEvent) bool {
 	var canHandleEvent bool
 

pkg/kube_events_manager/kube_events_manager.go

@@ -11,7 +11,7 @@ import (
 	metricsstorage "github.com/deckhouse/deckhouse/pkg/metrics-storage"
 
 	klient "github.com/flant/kube-client/client"
-	pkg "github.com/flant/shell-operator/pkg"
+	"github.com/flant/shell-operator/pkg"
 	kemtypes "github.com/flant/shell-operator/pkg/kube_events_manager/types"
 )
 
@@ -92,9 +92,8 @@ func (mgr *kubeEventsManager) WithMetricStorage(mstor metricsstorage.Storage) {
 // TODO cleanup informers in case of error
 // TODO use Context to stop informers
 func (mgr *kubeEventsManager) AddMonitor(monitorConfig *MonitorConfig) error {
-	log.Debug("Add MONITOR",
-		slog.String(pkg.LogKeyConfig, fmt.Sprintf("%+v", monitorConfig)))
-	monitor := NewMonitor(
+	mgr.logger.Debug("add kubernetes monitor", slog.String(pkg.LogKeyConfig, fmt.Sprintf("%+v", monitorConfig)))
+	mon := NewMonitor(
 		mgr.ctx,
 		mgr.KubeClient,
 		mgr.metricStorage,
@@ -107,13 +106,12 @@ func (mgr *kubeEventsManager) AddMonitor(monitorConfig *MonitorConfig) error {
 		mgr.logger.Named("monitor"),
 	)
 
-	err := monitor.CreateInformers()
-	if err != nil {
+	if err := mon.CreateInformers(); err != nil {
 		return err
 	}
 
 	mgr.m.Lock()
-	mgr.Monitors[monitorConfig.Metadata.MonitorId] = monitor
+	mgr.Monitors[monitorConfig.Metadata.MonitorId] = mon
 	mgr.m.Unlock()
 
 	return nil