fix: resolve CI failures in build-test and lint workflows

- Fix hardcoded /Users/bowen path in main_test.go; use runtime.Caller
  to resolve cmd/flashduty directory portably across CI environments
- Fix fmt import missing from main_test.go after prior refactor
- Remove unnecessary fmt.Sprintf (staticcheck S1039)
- Add _, _ = prefix to all unchecked fmt.Fprintf/Fprintln calls
  (errcheck) across 10 command files
- Suppress footer lines (Total:, Showing N) in --json mode to
  produce valid JSON output

Author: debidong

cmd/flashduty/main_test.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 )
@@ -37,9 +39,9 @@ func TestErrorFormatToStderr(t *testing.T) {
 
 	// We use a different strategy: build the binary, run it with a bad
 	// subcommand, and inspect stderr.
-	binPath := t.TempDir() + "/flashduty-test"
+	binPath := filepath.Join(t.TempDir(), "flashduty-test")
 	build := exec.Command("go", "build", "-o", binPath, ".")
-	build.Dir = "/Users/bowen/go/src/github.com/flashcatcloud/flashduty-cli/cmd/flashduty"
+	build.Dir = testMainDir(t)
 	if out, err := build.CombinedOutput(); err != nil {
 		t.Fatalf("[#77] failed to build test binary: %v\n%s", err, out)
 	}
@@ -81,15 +83,13 @@ func TestErrorFormatToStderr(t *testing.T) {
 // Test 78: SetVersionInfo before Execute -- version/commit/date set by main
 // are reflected in the `version` subcommand output.
 func TestSetVersionInfoBeforeExecute(t *testing.T) {
-	binPath := t.TempDir() + "/flashduty-test"
+	binPath := filepath.Join(t.TempDir(), "flashduty-test")
 
 	// Build with custom ldflags to inject known version info, just like the
 	// real release build does.
-	ldflags := fmt.Sprintf(
-		"-X main.version=1.2.3-test -X main.commit=abc1234 -X main.date=2026-04-13",
-	)
+	ldflags := "-X main.version=1.2.3-test -X main.commit=abc1234 -X main.date=2026-04-13"
 	build := exec.Command("go", "build", "-ldflags", ldflags, "-o", binPath, ".")
-	build.Dir = "/Users/bowen/go/src/github.com/flashcatcloud/flashduty-cli/cmd/flashduty"
+	build.Dir = testMainDir(t)
 	if out, err := build.CombinedOutput(); err != nil {
 		t.Fatalf("[#78] failed to build test binary: %v\n%s", err, out)
 	}
@@ -114,3 +114,14 @@ func TestSetVersionInfoBeforeExecute(t *testing.T) {
 		}
 	}
 }
+
+// testMainDir returns the directory of cmd/flashduty/main.go relative to this
+// test file, so it works both locally and in CI.
+func testMainDir(t *testing.T) string {
+	t.Helper()
+	_, filename, _, ok := runtime.Caller(0)
+	if !ok {
+		t.Fatal("could not determine test file path")
+	}
+	return filepath.Dir(filename)
+}

internal/cli/change.go

@@ -67,7 +67,7 @@ func newChangeListCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Showing %d results (page %d, total %d).\n", len(result.Changes), page, result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Showing %d results (page %d, total %d).\n", len(result.Changes), page, result.Total)
 			}
 			return nil
 		},

internal/cli/channel.go

@@ -49,7 +49,7 @@ func newChannelListCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
 			}
 			return nil
 		},

internal/cli/config.go

@@ -32,8 +32,8 @@ func newConfigShowCmd() *cobra.Command {
 				displayKey = "(not set)"
 			}
 
-			fmt.Fprintf(cmd.OutOrStdout(), "app_key:  %s %s\n", displayKey, config.ConfigSource("app_key"))
-			fmt.Fprintf(cmd.OutOrStdout(), "base_url: %s %s\n", cfg.BaseURL, config.ConfigSource("base_url"))
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "app_key:  %s %s\n", displayKey, config.ConfigSource("app_key"))
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "base_url: %s %s\n", cfg.BaseURL, config.ConfigSource("base_url"))
 			return nil
 		},
 	}
@@ -66,7 +66,7 @@ func newConfigSetCmd() *cobra.Command {
 				return err
 			}
 
-			fmt.Fprintf(cmd.OutOrStdout(), "Set %s successfully.\n", key)
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Set %s successfully.\n", key)
 			return nil
 		},
 	}

internal/cli/escalation_rule.go

@@ -83,9 +83,9 @@ func resolveChannelID(cmd *cobra.Command, client flashdutyClient, name string) (
 	case 1:
 		return result.Channels[0].ChannelID, nil
 	default:
-		fmt.Fprintln(cmd.OutOrStdout(), "Multiple channels match:")
+		_, _ = fmt.Fprintln(cmd.OutOrStdout(), "Multiple channels match:")
 		for _, ch := range result.Channels {
-			fmt.Fprintf(cmd.OutOrStdout(), "  %d  %s\n", ch.ChannelID, ch.ChannelName)
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "  %d  %s\n", ch.ChannelID, ch.ChannelName)
 		}
 		return 0, fmt.Errorf("multiple channels match %q, use --channel <id> to specify", name)
 	}

internal/cli/field.go

@@ -52,7 +52,7 @@ func newFieldListCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
 			}
 			return nil
 		},

internal/cli/incident.go

@@ -86,7 +86,7 @@ func newIncidentListCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Showing %d results (page %d, total %d).\n", len(result.Incidents), page, result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Showing %d results (page %d, total %d).\n", len(result.Incidents), page, result.Total)
 			}
 			return nil
 		},
@@ -155,18 +155,18 @@ func printIncidentDetail(w io.Writer, inc flashduty.EnrichedIncident) {
 		fields = append(fields, fmt.Sprintf("%s=%v", k, v))
 	}
 
-	fmt.Fprintf(w, "ID:            %s\n", inc.IncidentID)
-	fmt.Fprintf(w, "Title:         %s\n", inc.Title)
-	fmt.Fprintf(w, "Severity:      %s\n", inc.Severity)
-	fmt.Fprintf(w, "Progress:      %s\n", inc.Progress)
-	fmt.Fprintf(w, "Channel:       %s\n", inc.ChannelName)
-	fmt.Fprintf(w, "Created:       %s\n", output.FormatTime(inc.StartTime))
-	fmt.Fprintf(w, "Creator:       %s (%s)\n", inc.CreatorName, inc.CreatorEmail)
-	fmt.Fprintf(w, "Responders:    %s\n", orDash(strings.Join(responders, ", ")))
-	fmt.Fprintf(w, "Description:   %s\n", orDash(inc.Description))
-	fmt.Fprintf(w, "Labels:        %s\n", orDash(strings.Join(labels, ", ")))
-	fmt.Fprintf(w, "Custom Fields: %s\n", orDash(strings.Join(fields, ", ")))
-	fmt.Fprintf(w, "Alerts:        %d total\n", inc.AlertsTotal)
+	_, _ = fmt.Fprintf(w, "ID:            %s\n", inc.IncidentID)
+	_, _ = fmt.Fprintf(w, "Title:         %s\n", inc.Title)
+	_, _ = fmt.Fprintf(w, "Severity:      %s\n", inc.Severity)
+	_, _ = fmt.Fprintf(w, "Progress:      %s\n", inc.Progress)
+	_, _ = fmt.Fprintf(w, "Channel:       %s\n", inc.ChannelName)
+	_, _ = fmt.Fprintf(w, "Created:       %s\n", output.FormatTime(inc.StartTime))
+	_, _ = fmt.Fprintf(w, "Creator:       %s (%s)\n", inc.CreatorName, inc.CreatorEmail)
+	_, _ = fmt.Fprintf(w, "Responders:    %s\n", orDash(strings.Join(responders, ", ")))
+	_, _ = fmt.Fprintf(w, "Description:   %s\n", orDash(inc.Description))
+	_, _ = fmt.Fprintf(w, "Labels:        %s\n", orDash(strings.Join(labels, ", ")))
+	_, _ = fmt.Fprintf(w, "Custom Fields: %s\n", orDash(strings.Join(fields, ", ")))
+	_, _ = fmt.Fprintf(w, "Alerts:        %d total\n", inc.AlertsTotal)
 }
 
 func orDash(s string) string {
@@ -353,7 +353,7 @@ func newIncidentTimelineCmd() *cobra.Command {
 			}
 
 			if len(results) == 0 || len(results[0].Timeline) == 0 {
-				fmt.Fprintln(cmd.OutOrStdout(), "No timeline events.")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "No timeline events.")
 				return nil
 			}
 
@@ -394,7 +394,7 @@ func newIncidentAlertsCmd() *cobra.Command {
 			}
 
 			if len(results) == 0 || len(results[0].Alerts) == 0 {
-				fmt.Fprintln(cmd.OutOrStdout(), "No alerts.")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "No alerts.")
 				return nil
 			}
 
@@ -411,7 +411,7 @@ func newIncidentAlertsCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", results[0].Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", results[0].Total)
 			}
 			return nil
 		},
@@ -440,7 +440,7 @@ func newIncidentSimilarCmd() *cobra.Command {
 			}
 
 			if len(result.Incidents) == 0 {
-				fmt.Fprintln(cmd.OutOrStdout(), "No similar incidents found.")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "No similar incidents found.")
 				return nil
 			}
 

internal/cli/member.go

@@ -67,12 +67,12 @@ func newMemberListCmd() *cobra.Command {
 				if flagJSON {
 					return newPrinter(cmd.OutOrStdout()).Print([]struct{}{}, nil)
 				}
-				fmt.Fprintln(cmd.OutOrStdout(), "No members found.")
+				_, _ = fmt.Fprintln(cmd.OutOrStdout(), "No members found.")
 				return nil
 			}
 
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
 			}
 			return nil
 		},

internal/cli/root.go

@@ -135,9 +135,9 @@ func writeResult(w io.Writer, message string) {
 	}
 	if flagJSON {
 		out, _ := json.MarshalIndent(map[string]string{"message": message}, "", "  ")
-		fmt.Fprintln(w, string(out))
+		_, _ = fmt.Fprintln(w, string(out))
 	} else {
-		fmt.Fprintln(w, message)
+		_, _ = fmt.Fprintln(w, message)
 	}
 }
 

internal/cli/team.go

@@ -58,7 +58,7 @@ func newTeamListCmd() *cobra.Command {
 				return err
 			}
 			if !flagJSON {
-				fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
+				_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Total: %d\n", result.Total)
 			}
 			return nil
 		},