<EmailValidator>: EmailValidator does not conform to RFC standard

[jamal-o]

Is there an existing issue for this?

• I have searched the existing issues

Package/Plugin version

11.2.0

What you'd like to happen

The RegExp pattern does not conform to the RFC standard for email.

form_builder_validators/lib/src/network/email_validator.dart

Line 44 in f944f2b

r"^((([a-z]|\d|[!#\$%&'*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*)|((\x22)((((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(([\x01-\x08\x0b\x0c\x0e-\x1f\x7f]|\x21|[\x23-\x5b]|[\x5d-\x7e]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(\\([\x01-\x09\x0b\x0c\x0d-\x7f]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]))))*(((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(\x22)))@((([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.)+(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))$",

The email_validator package has an implementation that conforms to this.
I suggest that the package utilize this package for email validation or have an implementation of its own.

Alternatives you've considered

No response

Aditional information

No response

[jamal-o]

I'm open to working on this if it's decided to use the email_validator package.

[deandreamatias]

@jamal-o This is a feature I would investigate the best way to implement, but adding this dependency right now is definitely not a good idea because:

• It would create another dependency on an external package, something I'm trying to avoid.
• The email_validator package is not in a very active maintenance status.
• We have no control over there code or future conflicts/issues.
• Our focus on our validator package is the next major update (Dart fixes #161).

There are alternatives, such as changing the maintenance status of email_validator, modifying our email validator implementation, or even having @fredeil transfer the repository to @FlutterFormBuilderEcosystem.

[fredeil]

@jamal-o This is a feature I would investigate the best way to implement, but adding this dependency right now is definitely not a good idea because:

• It would create another dependency on an external package, something I'm trying to avoid.
• The email_validator package is not in a very active maintenance status.
• We have no control over there code or future conflicts/issues.
• Our focus on our validator package is the next major update (Dart fixes #161).

There are alternatives, such as changing the maintenance status of email_validator, modifying our email validator implementation, or even having @fredeil transfer the repository to @FlutterFormBuilderEcosystem.

The package hasn't received updates because it's feature-complete and stable. There are no open bugs, no breaking changes needed, and it conforms to RFC 5321/5322.

"Maintenance" doesn't mean churning out releases for the sake of activity. It means responding to issues and keeping the code working. Both boxes are checked.

For context: email_validator has 1.2k likes on pub.dev, 336k+ downloads, and is used by Google Firebase, Supabase, and Serverpod. If it was actually broken or unmaintained, those projects would have dropped it.

[deandreamatias]

@fredeil, fair points. Some things make sense to update on pub.dev, such as the READM, publisher verification, new Dart language features, etc., but I understand that this does not change the core feature.
Thank you for your response, which provides more context to this discussion.