style: misc

fulleni · fulleni · commit 3c38f6d587e7 · 2025-09-25T21:40:18.000+01:00
diff --git a/lib/app_configuration/view/app_configuration_page.dart b/lib/app_configuration/view/app_configuration_page.dart
@@ -53,7 +53,7 @@ class _AppConfigurationPageState extends State<AppConfigurationPage>
             ),
             const SizedBox(
               width: AppSpacing.sm,
-            ), // Spacing between title and icon
+            ),
             AboutIcon(
               dialogTitle: l10n.appConfigurationPageTitle,
               dialogDescription: l10n.appConfigurationPageDescription,
diff --git a/lib/app_configuration/widgets/feed_ad_settings_form.dart b/lib/app_configuration/widgets/feed_ad_settings_form.dart
@@ -49,8 +49,6 @@ class _FeedAdSettingsFormState extends State<FeedAdSettingsForm>
       vsync: this,
     );
     _initializeControllers();
-    // Removed _tabController.addListener(_onTabChanged); as automatic disabling
-    // for premium users is no longer required.
   }
 
   /// Initializes text editing controllers for each user role based on current
@@ -272,7 +270,6 @@ class _FeedAdSettingsFormState extends State<FeedAdSettingsForm>
     FeedAdConfiguration config,
   ) {
     final roleConfig = config.visibleTo[role];
-    // Removed isEnabled check as premium users can now be manually configured.
 
     return Column(
       children: [
diff --git a/lib/app_configuration/widgets/interstitial_ad_settings_form.dart b/lib/app_configuration/widgets/interstitial_ad_settings_form.dart
@@ -45,8 +45,6 @@ class _InterstitialAdSettingsFormState extends State<InterstitialAdSettingsForm>
       vsync: this,
     );
     _initializeControllers();
-    // Removed _tabController.addListener(_onTabChanged); as automatic disabling
-    // for premium users is no longer required.
   }
 
   /// Initializes text editing controllers for each user role based on current
@@ -204,7 +202,6 @@ class _InterstitialAdSettingsFormState extends State<InterstitialAdSettingsForm>
     InterstitialAdConfiguration config,
   ) {
     final roleConfig = config.visibleTo[role];
-    // Removed isEnabled check as premium users can now be manually configured.
 
     return Column(
       children: [
@@ -265,7 +262,6 @@ class _InterstitialAdSettingsFormState extends State<InterstitialAdSettingsForm>
               },
               controller:
                   _transitionsBeforeShowingInterstitialAdsControllers[role],
-              // Removed enabled: isEnabled
             ),
           ),
       ],
diff --git a/lib/content_management/bloc/content_management_state.dart b/lib/content_management/bloc/content_management_state.dart
@@ -122,11 +122,9 @@ class ContentManagementState extends Equatable {
       sources: sources ?? this.sources,
       sourcesCursor: sourcesCursor ?? this.sourcesCursor,
       sourcesHasMore: sourcesHasMore ?? this.sourcesHasMore,
-      exception: exception, // Explicitly set to null if not provided
-      lastPendingDeletionId:
-          lastPendingDeletionId, // Explicitly set to null if not provided
-      snackbarMessage:
-          snackbarMessage, // Explicitly set to null if not provided
+      exception: exception,
+      lastPendingDeletionId: lastPendingDeletionId,
+      snackbarMessage: snackbarMessage,
     );
   }
 
diff --git a/lib/content_management/view/content_management_page.dart b/lib/content_management/view/content_management_page.dart
@@ -1,4 +1,4 @@
-import 'package:collection/collection.dart'; // For deep equality check on filter maps
+import 'package:collection/collection.dart';
 import 'package:core/core.dart';
 import 'package:data_repository/data_repository.dart';
 import 'package:flutter/material.dart';
@@ -184,7 +184,7 @@ class _ContentManagementPageState extends State<ContentManagementPage>
               Text(l10n.contentManagement),
               const SizedBox(
                 width: AppSpacing.sm,
-              ), // Spacing between title and icon
+              ),
               AboutIcon(
                 dialogTitle: l10n.contentManagement,
                 dialogDescription: l10n.contentManagementPageDescription,
diff --git a/lib/content_management/view/headlines_page.dart b/lib/content_management/view/headlines_page.dart
@@ -4,7 +4,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/bloc/content_management_bloc.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/bloc/headlines_filter/headlines_filter_bloc.dart';
-import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/widgets/content_action_buttons.dart'; // Import the new widget
+import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/widgets/content_action_buttons.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/app_localizations.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/l10n.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/router/routes.dart';
@@ -146,7 +146,7 @@ class _HeadlinesPageState extends State<HeadlinesPage> {
                         headlines: state.headlines,
                         hasMore: state.headlinesHasMore,
                         l10n: l10n,
-                        isMobile: isMobile, // Pass isMobile to data source
+                        isMobile: isMobile,
                       ),
                       rowsPerPage: kDefaultRowsPerPage,
                       availableRowsPerPage: const [kDefaultRowsPerPage],
@@ -195,14 +195,14 @@ class _HeadlinesDataSource extends DataTableSource {
     required this.headlines,
     required this.hasMore,
     required this.l10n,
-    required this.isMobile, // New parameter
+    required this.isMobile,
   });
 
   final BuildContext context;
   final List<Headline> headlines;
   final bool hasMore;
   final AppLocalizations l10n;
-  final bool isMobile; // New parameter
+  final bool isMobile;
 
   @override
   DataRow? getRow(int index) {
diff --git a/lib/content_management/view/topics_page.dart b/lib/content_management/view/topics_page.dart
@@ -4,7 +4,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/bloc/content_management_bloc.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/bloc/topics_filter/topics_filter_bloc.dart';
-import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/widgets/content_action_buttons.dart'; // Import the new widget
+import 'package:flutter_news_app_web_dashboard_full_source_code/content_management/widgets/content_action_buttons.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/app_localizations.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/l10n.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/router/routes.dart';
@@ -136,7 +136,7 @@ class _TopicPageState extends State<TopicPage> {
                         topics: state.topics,
                         hasMore: state.topicsHasMore,
                         l10n: l10n,
-                        isMobile: isMobile, // Pass isMobile to data source
+                        isMobile: isMobile,
                       ),
                       rowsPerPage: kDefaultRowsPerPage,
                       availableRowsPerPage: const [kDefaultRowsPerPage],
@@ -185,14 +185,14 @@ class _TopicsDataSource extends DataTableSource {
     required this.topics,
     required this.hasMore,
     required this.l10n,
-    required this.isMobile, // New parameter
+    required this.isMobile,
   });
 
   final BuildContext context;
   final List<Topic> topics;
   final bool hasMore;
   final AppLocalizations l10n;
-  final bool isMobile; // New parameter
+  final bool isMobile;
 
   @override
   DataRow? getRow(int index) {
diff --git a/lib/content_management/widgets/content_action_buttons.dart b/lib/content_management/widgets/content_action_buttons.dart
@@ -47,7 +47,7 @@ class ContentActionButtons extends StatelessWidget {
       itemId = (item as Source).id;
       status = (item as Source).status;
     } else {
-      return const SizedBox.shrink(); // Should not happen with current FeedItem types
+      return const SizedBox.shrink();
     }
 
     // Action 1: Edit (always visible as the first action)
diff --git a/lib/content_management/widgets/filter_dialog/filter_dialog.dart b/lib/content_management/widgets/filter_dialog/filter_dialog.dart
@@ -389,7 +389,7 @@ class _FilterDialogState extends State<FilterDialog> {
           ],
         );
       case ContentManagementTab.topics:
-        return const SizedBox.shrink(); // No additional filters for topics
+        return const SizedBox.shrink();
       case ContentManagementTab.sources:
         return Column(
           crossAxisAlignment: CrossAxisAlignment.start,
diff --git a/lib/local_ads_management/bloc/create_local_ads/create_local_banner_ad_bloc.dart b/lib/local_ads_management/bloc/create_local_ads/create_local_banner_ad_bloc.dart
@@ -52,7 +52,7 @@ class CreateLocalBannerAdBloc
         targetUrl: state.targetUrl,
         createdAt: now,
         updatedAt: now,
-        status: ContentStatus.active, // Set status to active on creation
+        status: ContentStatus.active,
       );
 
       await _localAdsRepository.create(item: newLocalBannerAd);
diff --git a/lib/local_ads_management/bloc/create_local_ads/create_local_interstitial_ad_bloc.dart b/lib/local_ads_management/bloc/create_local_ads/create_local_interstitial_ad_bloc.dart
@@ -53,7 +53,7 @@ class CreateLocalInterstitialAdBloc
         targetUrl: state.targetUrl,
         createdAt: now,
         updatedAt: now,
-        status: ContentStatus.active, // Set status to active on creation
+        status: ContentStatus.active,
       );
 
       await _localAdsRepository.create(item: newLocalInterstitialAd);
diff --git a/lib/local_ads_management/bloc/create_local_ads/create_local_native_ad_bloc.dart b/lib/local_ads_management/bloc/create_local_ads/create_local_native_ad_bloc.dart
@@ -70,7 +70,7 @@ class CreateLocalNativeAdBloc
         targetUrl: state.targetUrl,
         createdAt: now,
         updatedAt: now,
-        status: ContentStatus.active, // Set status to active on creation
+        status: ContentStatus.active,
       );
 
       await _localAdsRepository.create(item: newLocalNativeAd);
diff --git a/lib/local_ads_management/bloc/create_local_ads/create_local_video_ad_bloc.dart b/lib/local_ads_management/bloc/create_local_ads/create_local_video_ad_bloc.dart
@@ -52,7 +52,7 @@ class CreateLocalVideoAdBloc
         targetUrl: state.targetUrl,
         createdAt: now,
         updatedAt: now,
-        status: ContentStatus.active, // Set status to active on creation
+        status: ContentStatus.active,
       );
 
       await _localAdsRepository.create(item: newLocalVideoAd);
diff --git a/lib/local_ads_management/bloc/update_local_ads/update_local_banner_ad_bloc.dart b/lib/local_ads_management/bloc/update_local_ads/update_local_banner_ad_bloc.dart
@@ -86,7 +86,7 @@ class UpdateLocalBannerAdBloc
         imageUrl: state.imageUrl,
         targetUrl: state.targetUrl,
         updatedAt: now,
-        status: state.initialAd!.status, // Maintain original status
+        status: state.initialAd!.status,
       );
 
       await _localAdsRepository.update(
diff --git a/lib/local_ads_management/bloc/update_local_ads/update_local_interstitial_ad_bloc.dart b/lib/local_ads_management/bloc/update_local_ads/update_local_interstitial_ad_bloc.dart
@@ -90,7 +90,7 @@ class UpdateLocalInterstitialAdBloc
         imageUrl: state.imageUrl,
         targetUrl: state.targetUrl,
         updatedAt: now,
-        status: state.initialAd!.status, // Maintain original status
+        status: state.initialAd!.status,
       );
 
       await _localAdsRepository.update(
diff --git a/lib/local_ads_management/bloc/update_local_ads/update_local_native_ad_bloc.dart b/lib/local_ads_management/bloc/update_local_ads/update_local_native_ad_bloc.dart
@@ -106,7 +106,7 @@ class UpdateLocalNativeAdBloc
         imageUrl: state.imageUrl,
         targetUrl: state.targetUrl,
         updatedAt: now,
-        status: state.initialAd!.status, // Maintain original status
+        status: state.initialAd!.status,
       );
 
       await _localAdsRepository.update(
diff --git a/lib/local_ads_management/bloc/update_local_ads/update_local_video_ad_bloc.dart b/lib/local_ads_management/bloc/update_local_ads/update_local_video_ad_bloc.dart
@@ -86,7 +86,7 @@ class UpdateLocalVideoAdBloc
         videoUrl: state.videoUrl,
         targetUrl: state.targetUrl,
         updatedAt: now,
-        status: state.initialAd!.status, // Maintain original status
+        status: state.initialAd!.status,
       );
 
       await _localAdsRepository.update(
diff --git a/lib/local_ads_management/view/local_ads_management_page.dart b/lib/local_ads_management/view/local_ads_management_page.dart
@@ -8,7 +8,6 @@ import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/app_localiz
 import 'package:flutter_news_app_web_dashboard_full_source_code/l10n/l10n.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/local_ads_management/bloc/local_ads_management_bloc.dart';
 import 'package:flutter_news_app_web_dashboard_full_source_code/router/routes.dart';
-// Added import
 import 'package:flutter_news_app_web_dashboard_full_source_code/shared/extensions/extensions.dart';
 import 'package:go_router/go_router.dart';
 import 'package:intl/intl.dart';
diff --git a/lib/router/router.dart b/lib/router/router.dart
@@ -1,5 +1,5 @@
 import 'package:auth_repository/auth_repository.dart';
-import 'package:core/core.dart' hide AppStatus; // Hide AppStatus from core.dart
+import 'package:core/core.dart' hide AppStatus;
 import 'package:data_repository/data_repository.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
diff --git a/lib/settings/view/settings_page.dart b/lib/settings/view/settings_page.dart
@@ -66,7 +66,7 @@ class _SettingsViewState extends State<_SettingsView> {
             Text(l10n.settings),
             const SizedBox(
               width: AppSpacing.sm,
-            ), // Spacing between title and icon
+            ),
             AboutIcon(
               dialogTitle: l10n.settings,
               dialogDescription: l10n.settingsPageDescription,
diff --git a/lib/shared/widgets/searchable_selection_input.dart b/lib/shared/widgets/searchable_selection_input.dart
@@ -26,15 +26,15 @@ class SearchableSelectionInput<T> extends StatefulWidget {
     required this.itemBuilder,
     required this.itemToString,
     required this.onChanged,
-    this.selectedItems, // Changed to List<T>?
+    this.selectedItems,
     this.repository,
     this.filterBuilder,
     this.sortOptions,
     this.limit,
     this.staticItems,
     this.includeInactiveSelectedItem = false,
-    this.isMultiSelect = false, // New parameter
-    this.hintText, // New parameter
+    this.isMultiSelect = false,
+    this.hintText,
     super.key,
   }) : assert(
          (repository != null &&
@@ -49,7 +49,7 @@ class SearchableSelectionInput<T> extends StatefulWidget {
   final String label;
 
   /// The currently selected item(s).
-  final List<T>? selectedItems; // Changed to List<T>?
+  final List<T>? selectedItems;
 
   /// If true, the [selectedItems] will be included in the fetched results
   /// even if they do not match the current filter criteria (e.g., if they are
@@ -66,7 +66,7 @@ class SearchableSelectionInput<T> extends StatefulWidget {
   final String Function(T item) itemToString;
 
   /// Callback when item(s) are selected or cleared.
-  final ValueChanged<List<T>?> onChanged; // Changed to ValueChanged<List<T>?>
+  final ValueChanged<List<T>?> onChanged;
 
   /// The [DataRepository] to use for fetching items (if not using static items).
   /// The generic type of the repository must match [T].
@@ -175,7 +175,7 @@ class _SearchableSelectionInputState<T>
     if (result != null) {
       widget.onChanged(result.cast<T>());
     } else {
-      widget.onChanged(null); // Clear selection if nothing was chosen
+      widget.onChanged(null);
     }
   }
 
@@ -187,7 +187,7 @@ class _SearchableSelectionInputState<T>
       readOnly: true,
       decoration: InputDecoration(
         labelText: widget.label,
-        hintText: widget.hintText, // Use new hintText parameter
+        hintText: widget.hintText,
         border: Theme.of(context).inputDecorationTheme.border,
         suffixIcon: IconButton(
           icon: const Icon(Icons.arrow_drop_down),
diff --git a/lib/shared/widgets/selection_page/bloc/searchable_selection_state.dart b/lib/shared/widgets/selection_page/bloc/searchable_selection_state.dart
@@ -23,7 +23,7 @@ final class SearchableSelectionState extends Equatable {
   const SearchableSelectionState({
     this.status = SearchableSelectionStatus.initial,
     this.items = const [],
-    this.selectedItems = const [], // Changed to List<Object>
+    this.selectedItems = const [],
     this.searchTerm = '',
     this.cursor,
     this.hasMore = true,
@@ -37,7 +37,7 @@ final class SearchableSelectionState extends Equatable {
   final List<Object> items;
 
   /// The currently selected items.
-  final List<Object> selectedItems; // Changed to List<Object>
+  final List<Object> selectedItems;
 
   /// The current search term applied to the items.
   final String searchTerm;
@@ -55,7 +55,7 @@ final class SearchableSelectionState extends Equatable {
   SearchableSelectionState copyWith({
     SearchableSelectionStatus? status,
     List<Object>? items,
-    List<Object>? selectedItems, // Changed to List<Object>
+    List<Object>? selectedItems,
     String? searchTerm,
     String? cursor,
     bool? hasMore,
@@ -64,7 +64,7 @@ final class SearchableSelectionState extends Equatable {
     return SearchableSelectionState(
       status: status ?? this.status,
       items: items ?? this.items,
-      selectedItems: selectedItems ?? this.selectedItems, // Updated
+      selectedItems: selectedItems ?? this.selectedItems,
       searchTerm: searchTerm ?? this.searchTerm,
       cursor: cursor ?? this.cursor,
       hasMore: hasMore ?? this.hasMore,
@@ -76,7 +76,7 @@ final class SearchableSelectionState extends Equatable {
   List<Object?> get props => [
     status,
     items,
-    selectedItems, // Updated
+    selectedItems,
     searchTerm,
     cursor,
     hasMore,
diff --git a/lib/shared/widgets/selection_page/searchable_selection_page.dart b/lib/shared/widgets/selection_page/searchable_selection_page.dart
@@ -129,7 +129,7 @@ class _SearchableSelectionViewState extends State<_SearchableSelectionView> {
           if (widget.arguments.isMultiSelect)
             IconButton(
               icon: const Icon(Icons.check),
-              tooltip: l10n.apply, // Assuming l10n.apply exists
+              tooltip: l10n.apply,
               onPressed: () {
                 // Return the locally managed selected items.
                 Navigator.of(context).pop(_tempSelectedItems);
diff --git a/lib/shared/widgets/selection_page/selection_page_arguments.dart b/lib/shared/widgets/selection_page/selection_page_arguments.dart

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class ContentActionButtons extends StatelessWidget {`
`47`	`47`	`itemId = (item as Source).id;`
`48`	`48`	`status = (item as Source).status;`
`49`	`49`	`} else {`
`50`		`- return const SizedBox.shrink(); // Should not happen with current FeedItem types`
	`50`	`+ return const SizedBox.shrink();`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`// Action 1: Edit (always visible as the first action)`