refactor(ad): simplify ad configuration form

- Remove articles before interstitial ad settings
- Add global ad enable/disable toggle
- Gray out settings when ads are disabled
- Reorganize layout for better clarity

Author: fulleni

lib/app_configuration/widgets/ad_config_form.dart

@@ -36,8 +36,6 @@ class _AdConfigFormState extends State<AdConfigForm>
   late final Map<AppUserRole, TextEditingController> _adFrequencyControllers;
   late final Map<AppUserRole, TextEditingController>
   _adPlacementIntervalControllers;
-  late final Map<AppUserRole, TextEditingController>
-  _articlesToReadBeforeShowingInterstitialAdsControllers;
 
   @override
   void initState() {
@@ -82,19 +80,6 @@ class _AdConfigFormState extends State<AdConfigForm>
                 ).toString().length,
               ),
     };
-    _articlesToReadBeforeShowingInterstitialAdsControllers = {
-      for (final role in AppUserRole.values)
-        role:
-            TextEditingController(
-                text: _getArticlesBeforeInterstitial(adConfig, role).toString(),
-              )
-              ..selection = TextSelection.collapsed(
-                offset: _getArticlesBeforeInterstitial(
-                  adConfig,
-                  role,
-                ).toString().length,
-              ),
-    };
   }
 
   void _updateControllers() {
@@ -120,20 +105,6 @@ class _AdConfigFormState extends State<AdConfigForm>
               offset: newPlacementIntervalValue.length,
             );
       }
-
-      final newInterstitialValue = _getArticlesBeforeInterstitial(
-        adConfig,
-        role,
-      ).toString();
-      if (_articlesToReadBeforeShowingInterstitialAdsControllers[role]?.text !=
-          newInterstitialValue) {
-        _articlesToReadBeforeShowingInterstitialAdsControllers[role]?.text =
-            newInterstitialValue;
-        _articlesToReadBeforeShowingInterstitialAdsControllers[role]
-            ?.selection = TextSelection.collapsed(
-          offset: newInterstitialValue.length,
-        );
-      }
     }
   }
 
@@ -146,10 +117,6 @@ class _AdConfigFormState extends State<AdConfigForm>
     for (final controller in _adPlacementIntervalControllers.values) {
       controller.dispose();
     }
-    for (final controller
-        in _articlesToReadBeforeShowingInterstitialAdsControllers.values) {
-      controller.dispose();
-    }
     super.dispose();
   }
 
@@ -161,44 +128,67 @@ class _AdConfigFormState extends State<AdConfigForm>
     return Column(
       crossAxisAlignment: CrossAxisAlignment.start,
       children: [
-        Text(
-          l10n.adSettingsDescription,
-          style: Theme.of(context).textTheme.bodySmall?.copyWith(
-            color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
-          ),
-        ),
-        const SizedBox(height: AppSpacing.lg),
-        // Replaced SegmentedButton with TabBar for role selection
-        Align(
-          alignment: AlignmentDirectional.centerStart,
-          child: SizedBox(
-            height: kTextTabBarHeight,
-            child: TabBar(
-              controller: _tabController,
-              tabAlignment: TabAlignment.start,
-              isScrollable: true,
-              tabs: AppUserRole.values
-                  .map((role) => Tab(text: role.l10n(context)))
-                  .toList(),
-            ),
-          ),
+        SwitchListTile(
+          title: Text(l10n.enableGlobalAdsLabel),
+          value: adConfig.enabled,
+          onChanged: (value) {
+            widget.onConfigChanged(
+              widget.remoteConfig.copyWith(
+                adConfig: adConfig.copyWith(enabled: value),
+              ),
+            );
+          },
         ),
         const SizedBox(height: AppSpacing.lg),
-        // TabBarView to display role-specific fields
-        SizedBox(
-          height: 400, // Fixed height for TabBarView within a ListView
-          child: TabBarView(
-            controller: _tabController,
-            children: AppUserRole.values
-                .map(
-                  (role) => _buildRoleSpecificFields(
-                    context,
-                    l10n,
-                    role,
-                    adConfig,
+        AbsorbPointer(
+          absorbing: !adConfig.enabled,
+          child: Opacity(
+            opacity: adConfig.enabled ? 1.0 : 0.5,
+            child: Column(
+              crossAxisAlignment: CrossAxisAlignment.start,
+              children: [
+                Text(
+                  l10n.adSettingsDescription,
+                  style: Theme.of(context).textTheme.bodySmall?.copyWith(
+                    color: Theme.of(
+                      context,
+                    ).colorScheme.onSurface.withOpacity(0.7),
                   ),
-                )
-                .toList(),
+                ),
+                const SizedBox(height: AppSpacing.lg),
+                Align(
+                  alignment: AlignmentDirectional.centerStart,
+                  child: SizedBox(
+                    height: kTextTabBarHeight,
+                    child: TabBar(
+                      controller: _tabController,
+                      tabAlignment: TabAlignment.start,
+                      isScrollable: true,
+                      tabs: AppUserRole.values
+                          .map((role) => Tab(text: role.l10n(context)))
+                          .toList(),
+                    ),
+                  ),
+                ),
+                const SizedBox(height: AppSpacing.lg),
+                SizedBox(
+                  height: 400,
+                  child: TabBarView(
+                    controller: _tabController,
+                    children: AppUserRole.values
+                        .map(
+                          (role) => _buildRoleSpecificFields(
+                            context,
+                            l10n,
+                            role,
+                            adConfig,
+                          ),
+                        )
+                        .toList(),
+                  ),
+                ),
+              ],
+            ),
           ),
         ),
       ],
@@ -239,24 +229,6 @@ class _AdConfigFormState extends State<AdConfigForm>
           },
           controller: _adPlacementIntervalControllers[role],
         ),
-        AppConfigIntField(
-          label: l10n.articlesBeforeInterstitialAdsLabel,
-          description: l10n.articlesBeforeInterstitialAdsDescription,
-          value: _getArticlesBeforeInterstitial(config, role),
-          onChanged: (value) {
-            widget.onConfigChanged(
-              widget.remoteConfig.copyWith(
-                adConfig: _updateArticlesBeforeInterstitial(
-                  config,
-                  value,
-                  role,
-                ),
-              ),
-            );
-          },
-          controller:
-              _articlesToReadBeforeShowingInterstitialAdsControllers[role],
-        ),
       ],
     );
   }
@@ -295,29 +267,6 @@ class _AdConfigFormState extends State<AdConfigForm>
     }
   }
 
-  int _getArticlesBeforeInterstitial(AdConfig config, AppUserRole role) {
-    switch (role) {
-      case AppUserRole.guestUser:
-        return config
-            .articleAdConfiguration
-            .interstitialAdConfiguration
-            .frequencyConfig
-            .guestArticlesToReadBeforeShowingInterstitialAds;
-      case AppUserRole.standardUser:
-        return config
-            .articleAdConfiguration
-            .interstitialAdConfiguration
-            .frequencyConfig
-            .standardUserArticlesToReadBeforeShowingInterstitialAds;
-      case AppUserRole.premiumUser:
-        return config
-            .articleAdConfiguration
-            .interstitialAdConfiguration
-            .frequencyConfig
-            .premiumUserArticlesToReadBeforeShowingInterstitialAds;
-    }
-  }
-
   AdConfig _updateAdFrequency(AdConfig config, int value, AppUserRole role) {
     switch (role) {
       case AppUserRole.guestUser:
@@ -373,41 +322,4 @@ class _AdConfigFormState extends State<AdConfigForm>
         );
     }
   }
-
-  AdConfig _updateArticlesBeforeInterstitial(
-    AdConfig config,
-    int value,
-    AppUserRole role,
-  ) {
-    final currentFrequencyConfig = config
-        .articleAdConfiguration
-        .interstitialAdConfiguration
-        .frequencyConfig;
-
-    ArticleInterstitialAdFrequencyConfig newFrequencyConfig;
-
-    switch (role) {
-      case AppUserRole.guestUser:
-        newFrequencyConfig = currentFrequencyConfig.copyWith(
-          guestArticlesToReadBeforeShowingInterstitialAds: value,
-        );
-      case AppUserRole.standardUser:
-        newFrequencyConfig = currentFrequencyConfig.copyWith(
-          standardUserArticlesToReadBeforeShowingInterstitialAds: value,
-        );
-      case AppUserRole.premiumUser:
-        newFrequencyConfig = currentFrequencyConfig.copyWith(
-          premiumUserArticlesToReadBeforeShowingInterstitialAds: value,
-        );
-    }
-
-    return config.copyWith(
-      articleAdConfiguration: config.articleAdConfiguration.copyWith(
-        interstitialAdConfiguration: config
-            .articleAdConfiguration
-            .interstitialAdConfiguration
-            .copyWith(frequencyConfig: newFrequencyConfig),
-      ),
-    );
-  }
 }