Skip to content

Commit f90ebe6

Browse files
committed
refactor(app_configuration): improve AD platform config form layout
- Update EdgeInsets to EdgeInsetsDirectional for better RTL support - Adjust padding and alignment for better hierarchy and consistency - Improve text alignment for ExpansionTile children
1 parent d92ab18 commit f90ebe6

File tree

1 file changed

+19
-10
lines changed

1 file changed

+19
-10
lines changed

lib/app_configuration/widgets/ad_platform_config_form.dart

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class AdPlatformConfigForm extends StatefulWidget {
2929
class _AdPlatformConfigFormState extends State<AdPlatformConfigForm> {
3030
late AdPlatformType _selectedPlatform;
3131
late Map<AdPlatformType, Map<String, TextEditingController>>
32-
_platformAdIdentifierControllers;
32+
_platformAdIdentifierControllers;
3333

3434
@override
3535
void initState() {
@@ -185,16 +185,19 @@ class _AdPlatformConfigFormState extends State<AdPlatformConfigForm> {
185185
// Primary Ad Platform Selection
186186
ExpansionTile(
187187
title: Text(l10n.primaryAdPlatformTitle),
188-
childrenPadding: const EdgeInsets.symmetric(
189-
horizontal: AppSpacing.xxl,
190-
vertical: AppSpacing.md,
188+
childrenPadding: const EdgeInsetsDirectional.only(
189+
start: AppSpacing.lg, // Adjusted padding for hierarchy
190+
top: AppSpacing.md,
191+
bottom: AppSpacing.md,
191192
),
193+
expandedCrossAxisAlignment: CrossAxisAlignment.start, // Align content to start
192194
children: [
193195
Text(
194196
l10n.primaryAdPlatformDescription,
195197
style: Theme.of(context).textTheme.bodySmall?.copyWith(
196198
color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
197199
),
200+
textAlign: TextAlign.start, // Ensure text aligns to start
198201
),
199202
const SizedBox(height: AppSpacing.lg),
200203
Align(
@@ -235,16 +238,19 @@ class _AdPlatformConfigFormState extends State<AdPlatformConfigForm> {
235238
// Ad Unit Identifiers
236239
ExpansionTile(
237240
title: Text(l10n.adUnitIdentifiersTitle),
238-
childrenPadding: const EdgeInsets.symmetric(
239-
horizontal: AppSpacing.xxl,
240-
vertical: AppSpacing.md,
241+
childrenPadding: const EdgeInsetsDirectional.only(
242+
start: AppSpacing.lg, // Adjusted padding for hierarchy
243+
top: AppSpacing.md,
244+
bottom: AppSpacing.md,
241245
),
246+
expandedCrossAxisAlignment: CrossAxisAlignment.start, // Align content to start
242247
children: [
243248
Text(
244249
l10n.adUnitIdentifiersDescription,
245250
style: Theme.of(context).textTheme.bodySmall?.copyWith(
246251
color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
247252
),
253+
textAlign: TextAlign.start, // Ensure text aligns to start
248254
),
249255
const SizedBox(height: AppSpacing.lg),
250256
_buildAdUnitIdentifierFields(
@@ -261,10 +267,12 @@ class _AdPlatformConfigFormState extends State<AdPlatformConfigForm> {
261267
if (_selectedPlatform == AdPlatformType.local)
262268
ExpansionTile(
263269
title: Text(l10n.localAdManagementTitle),
264-
childrenPadding: const EdgeInsets.symmetric(
265-
horizontal: AppSpacing.xxl,
266-
vertical: AppSpacing.md,
270+
childrenPadding: const EdgeInsetsDirectional.only(
271+
start: AppSpacing.lg, // Adjusted padding for hierarchy
272+
top: AppSpacing.md,
273+
bottom: AppSpacing.md,
267274
),
275+
expandedCrossAxisAlignment: CrossAxisAlignment.start, // Align content to start
268276
children: [
269277
Text(
270278
l10n.localAdManagementDescription,
@@ -273,6 +281,7 @@ class _AdPlatformConfigFormState extends State<AdPlatformConfigForm> {
273281
context,
274282
).colorScheme.onSurface.withOpacity(0.7),
275283
),
284+
textAlign: TextAlign.start, // Ensure text aligns to start
276285
),
277286
const SizedBox(height: AppSpacing.lg),
278287
Center(

0 commit comments

Comments
 (0)