Skip to content

Commit 0422ff2

Browse files
authored
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443) (#7444)
F# Compiler is emitting the incorrect minor version number for Debug Directory entry type #19 (PDB Checksum). This bug seems like either a copy/paste error or human error. 0x0100 is the correct minor version number for embedded pdb info, but 0 is the correct minor version number for pdb checksum as spec'd here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md#pdb-checksum-debug-directory-entry-type-19 This issues causes the VS Debugger to ignore PDB Checksum entries in F# pdbs, which breaks NuGet.org Symbol Server scenarios for F#.
1 parent 256341a commit 0422ff2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/absil/ilwritepdb.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ let pdbChecksumDebugInfo timestamp (checksumPdbChunk: BinaryChunk) (algorithmNam
203203
buffer
204204
{ iddCharacteristics = 0 // Reserved
205205
iddMajorVersion = 1 // VersionMajor should be 1
206-
iddMinorVersion = 0x0100 // VersionMinor should be 0x0100
206+
iddMinorVersion = 0 // VersionMinor should be 0
207207
iddType = 19 // IMAGE_DEBUG_TYPE_CHECKSUMPDB
208208
iddTimestamp = timestamp
209209
iddData = iddBuffer // Path name to the pdb file when built

0 commit comments

Comments
 (0)