Fix 592 - bad metadata for fake event properties

Author: dsyme

src/fsharp/TypeRelations.fs

@@ -1438,9 +1438,11 @@ module DispatchSlotChecking =
         allImmediateMembersThatMightImplementDispatchSlots |> List.iter (fun overrideBy -> 
 
             let isFakeEventProperty = overrideBy.IsFSharpEventProperty(g)
-            if not isFakeEventProperty then 
-                
-                let overriden = 
+            let overriden = 
+                if isFakeEventProperty then 
+                    let slotsigs = overrideBy.MemberInfo.Value.ImplementedSlotSigs 
+                    slotsigs |> List.map (ReparentSlotSigToUseMethodTypars g overrideBy.Range overrideBy)
+                else
                     [ for ((reqdTy,m),(SlotImplSet(_dispatchSlots,dispatchSlotsKeyed,_,_))) in allImpls do
                           let overrideByInfo = GetTypeMemberOverrideInfo g reqdTy overrideBy
                           let overridenForThisSlotImplSet = 
@@ -1466,7 +1468,7 @@ module DispatchSlotChecking =
                           //    assert nonNil overridenForThisSlotImplSet
                           yield! overridenForThisSlotImplSet ]
 
-                overrideBy.MemberInfo.Value.ImplementedSlotSigs <- overriden)
+            overrideBy.MemberInfo.Value.ImplementedSlotSigs <- overriden)
 
 
 //-------------------------------------------------------------------------

tests/fsharp/typecheck/sigs/neg94-pre.fs

@@ -1,5 +1,19 @@
 namespace Neg94Pre
 
+open System
+
 type Class1() =
   static member inline ($) (r:'R, _) = fun (x:'T) -> ((^R) : (static member method2: ^T -> ^R) x)
-  static member inline method1 x = Unchecked.defaultof<'r> $ Class1()
+  static member inline method1 x = Unchecked.defaultof<'r> $ Class1()
+
+type IComm = 
+    [<CLIEvent>]
+    abstract CanExecuteChanged : IEvent<EventHandler,EventArgs> 
+
+type Interface2<'T> =
+    inherit IComm
+
+type Class<'T>() =
+    interface Interface2<'T> with
+        [<CLIEvent>]
+        member __.CanExecuteChanged : IEvent<EventHandler,EventArgs> = Event<EventHandler,EventArgs>().Publish

tests/fsharp/typecheck/sigs/neg94.fs

@@ -6,5 +6,7 @@ module Repro1 =
   let v2 = undefined  
   // We're expecting the compile of this file to fail, but the point is that the 
   // reference of neg94-pre.dll shouldn't give extra warnings about bad definitions.
-  // See https://github.com/Microsoft/visualfsharp/issues/631
+  // See 
+  //    https://github.com/Microsoft/visualfsharp/issues/631
+  //    https://github.com/Microsoft/visualfsharp/issues/592