Consider '_' for members with access modifiers (#7631)

* Consider '_' for members with access modifiers

* Add tests

* Revert

* Add tests with modifiers

Author: gusty

src/fsharp/pars.fsy

@@ -1924,6 +1924,11 @@ atomicPatternLongIdent:
     }
   | GLOBAL DOT pathOp  { let (LongIdentWithDots(lid,dotms)) = $3 in (None,LongIdentWithDots(ident(MangledGlobalName,rhs parseState 1) :: lid, rhs parseState 2 :: dotms)) }
   | pathOp { (None,$1) }
+  | access UNDERSCORE DOT pathOp {
+    if not (parseState.LexBuffer.SupportsFeature LanguageFeature.SingleUnderscorePattern) then
+        raiseParseErrorAt (rhs parseState 2) (FSComp.SR.parsUnexpectedSymbolDot())
+    let (LongIdentWithDots(lid,dotms)) = $4 in (Some($1),LongIdentWithDots(ident("_",rhs parseState 1)::lid, rhs parseState 2::dotms))
+    }  
   | access pathOp { (Some($1), $2) }
 
 

tests/fsharp/core/members/self-identifier/version47/test.fs

@@ -26,19 +26,46 @@ type MyStructWithUnderscoreIdentifier =
     member _.MethodWithUnderscoreSelf() = true
     member __.MethodWithDoubleUnderscoreSelf() = true
     member _E.MethodWithUnderscoreESelf() = true
+    member private _.PrivateMethodWithUnderscoreSelf() = true
+    member private __.PrivateMethodWithDoubleUnderscoreSelf() = true
+    member private _E.PrivateMethodWithUnderscoreESelf() = true
+    member inline _.InlineMethodWithUnderscoreSelf() = true
+    member inline __.InlineMethodWithDoubleUnderscoreSelf() = true
+    member inline _E.InlineMethodWithUnderscoreESelf() = true
+    member inline private _.InlinePrivateMethodWithUnderscoreSelf() = true
+    member inline private __.InlinePrivateMethodWithDoubleUnderscoreSelf() = true
+    member inline private _E.InlinePrivateMethodWithUnderscoreESelf() = true
 
 type MyClassWithUnderscoreIdentifier () =
     class
         member _.MethodWithUnderscoreSelf() = true
         member __.MethodWithDoubleUnderscoreSelf() = true
         member _E.MethodWithUnderscoreESelf() = true
+        member private _.PrivateMethodWithUnderscoreSelf() = true
+        member private __.PrivateMethodWithDoubleUnderscoreSelf() = true
+        member private _E.PrivateMethodWithUnderscoreESelf() = true
+        member inline _.InlineMethodWithUnderscoreSelf() = true
+        member inline __.InlineMethodWithDoubleUnderscoreSelf() = true
+        member inline _E.InlineMethodWithUnderscoreESelf() = true
+        member inline private _.InlinePrivateMethodWithUnderscoreSelf() = true
+        member inline private __.InlinePrivateMethodWithDoubleUnderscoreSelf() = true
+        member inline private _E.InlinePrivateMethodWithUnderscoreESelf() = true
     end
 
 type MyStructTypeWithUnderscoreIdentifier =
     struct
         member _.MethodWithUnderscoreSelf() = true
         member __.MethodWithDoubleUnderscoreSelf() = true
         member _E.MethodWithUnderscoreESelf() = true
+        member private _.PrivateMethodWithUnderscoreSelf() = true
+        member private __.PrivateMethodWithDoubleUnderscoreSelf() = true
+        member private _E.PrivateMethodWithUnderscoreESelf() = true
+        member inline _.InlineMethodWithUnderscoreSelf() = true
+        member inline __.InlineMethodWithDoubleUnderscoreSelf() = true
+        member inline _E.InlineMethodWithUnderscoreESelf() = true
+        member inline private _.InlinePrivateMethodWithUnderscoreSelf() = true
+        member inline private __.InlinePrivateMethodWithDoubleUnderscoreSelf() = true
+        member inline private _E.InlinePrivateMethodWithUnderscoreESelf() = true
     end