Skip to content

Commit 8efd7f7

Browse files
authored
Merge pull request #1328 from dsyme/improve-1293
improve error message related to 1293
2 parents 47dd515 + 6a18c0c commit 8efd7f7

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/fsharp/FSComp.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ tcUnexpectedConstByteArray,"Unexpected Const_bytearray"
464464
641,tcReturnValuesCannotHaveNames,"Return values cannot have names"
465465
tcMemberKindPropertyGetSetNotExpected,"MemberKind.PropertyGetSet only expected in parse trees"
466466
201,tcNamespaceCannotContainValues,"Namespaces cannot contain values. Consider using a module to hold your value declarations."
467-
644,tcNamespaceCannotContainExtensionMembers,"Namespaces cannot contain extension members except in the same file and namespace where the type is defined. Consider using a module to hold declarations of extension members."
467+
644,tcNamespaceCannotContainExtensionMembers,"Namespaces cannot contain extension members except in the same file and namespace declaration group where the type is defined. Consider using a module to hold declarations of extension members."
468468
645,tcMultipleVisibilityAttributes,"Multiple visibility attributes have been specified for this identifier"
469469
646,tcMultipleVisibilityAttributesWithLet,"Multiple visibility attributes have been specified for this identifier. 'let' bindings in classes are always private, as are any 'let' bindings inside expressions."
470470
tcInvalidMethodNameForRelationalOperator,"The name '(%s)' should not be used as a member name. To define comparison semantics for a type, implement the 'System.IComparable' interface. If defining a static member for use from other CLI languages then use the name '%s' instead."

tests/fsharp/typecheck/sigs/neg16.bsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
neg16.fs(7,13,7,16): typecheck error FS0644: Namespaces cannot contain extension members except in the same file and namespace where the type is defined. Consider using a module to hold declarations of extension members.
2+
neg16.fs(7,13,7,16): typecheck error FS0644: Namespaces cannot contain extension members except in the same file and namespace declaration group where the type is defined. Consider using a module to hold declarations of extension members.
33

44
neg16.fs(23,10,23,11): typecheck error FS0935: Types with the 'AllowNullLiteral' attribute may only inherit from or implement types which also allow the use of the null literal
55

tests/fsharpqa/Source/Conformance/ObjectOrientedTypeDefinitions/TypeExtensions/basic/E_ExtensionInNamespace01.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Verify error associated with placing type extensions
33
// inside namespaces. (They must only be placed in modules.)
44

5-
//<Expects id="FS0644" span="(10,17-10,32)" status="error">Namespaces cannot contain extension members except in the same file and namespace where the type is defined\. Consider using a module to hold declarations of extension members\.$</Expects>
5+
//<Expects id="FS0644" span="(10,17-10,32)" status="error">Namespaces cannot contain extension members except in the same file and namespace declaration group where the type is defined\. Consider using a module to hold declarations of extension members\.$</Expects>
66

77
namespace System
88

tests/fsharpqa/Source/Conformance/ObjectOrientedTypeDefinitions/TypeExtensions/optional/E_NotInModule.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// #Regression #Conformance #ObjectOrientedTypes #TypeExtensions
22
// Verify that optional extension must be inside a module
3-
//<Expects id="FS0644" status="error" span="(9,20-9,35)">Namespaces cannot contain extension members except in the same file and namespace where the type is defined\. Consider using a module to hold declarations of extension members\.$</Expects>
3+
//<Expects id="FS0644" status="error" span="(9,20-9,35)">Namespaces cannot contain extension members except in the same file and namespace declaration group where the type is defined\. Consider using a module to hold declarations of extension members\.$</Expects>
44

55
namespace NS
66
type Lib with

0 commit comments

Comments
 (0)