Skip to content

Commit 93b54c8

Browse files
author
Omar Tawfik
committed
Make language packs optional
1 parent 9d037c0 commit 93b54c8

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

setup/Swix/Microsoft.FSharp.Dependencies/Files.swr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use vs
22

33
package name=Microsoft.FSharp.Dependencies
44
version=4.1
5-
vs.package.language=en-us
5+
vs.package.language=neutral
66

77
folder "InstallDir:MSBuild\Microsoft\VisualStudio\v15.0\FSharp"
88
file "Microsoft.FSharp.targets" source="$(BinariesFolder)\setup\resources\Microsoft.FSharp.Shim.targets"

setup/Swix/Microsoft.FSharp.SDK/Files.swr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use vs
33
package name=Microsoft.FSharp.SDK
44
version=4.1
55
vs.package.type=msi
6-
vs.package.language=$(LocaleRegion)
6+
vs.package.language=$(SwixPackageLanguage)
77

88
vs.payloads
99
vs.payload source="$(BinariesFolder)\msi\Microsoft.FSharp.SDK.$(LocaleCode).msi"

setup/Swix/Microsoft.FSharp.SDK/Microsoft.FSharp.SDK.swixproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,15 @@
1515
<Import Project="$(FSharpSourcesRoot)\Microbuild.Settings.targets" />
1616

1717
<PropertyGroup>
18+
<SwixPackageLanguage Condition="'$(IsLangPack)' == 'true'">$(LocaleRegion)</SwixPackageLanguage>
19+
<SwixPackageLanguage Condition="'$(IsLangPack)' == 'false'">neutral</SwixPackageLanguage>
20+
1821
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);BinariesFolder=$(BinariesFolder)</PackagePreprocessorDefinitions>
1922
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);LocaleCode=$(LocaleCode)</PackagePreprocessorDefinitions>
2023
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);LocaleId=$(LocaleId)</PackagePreprocessorDefinitions>
2124
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);LocaleRegion=$(LocaleRegion)</PackagePreprocessorDefinitions>
25+
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);IsLangPack=$(IsLangPack)</PackagePreprocessorDefinitions>
26+
<PackagePreprocessorDefinitions>$(PackagePreprocessorDefinitions);SwixPackageLanguage=$(SwixPackageLanguage)</PackagePreprocessorDefinitions>
2227
</PropertyGroup>
2328

2429
<ItemGroup>
@@ -29,5 +34,6 @@
2934
<Error Condition="'$(LocaleCode)' == ''" Text="A 'LocaleCode' property must be passed to the project." />
3035
<Error Condition="'$(LocaleId)' == ''" Text="A 'LocaleId' property must be passed to the project." />
3136
<Error Condition="'$(LocaleRegion)' == ''" Text="A 'LocaleRegion' property must be passed to the project." />
37+
<Error Condition="'$(IsLangPack)' == ''" Text="A 'IsLangPack' property must be passed to the project." />
3238
</Target>
3339
</Project>

setup/Swix/Microsoft.FSharp.Vsix/Files.swr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ use vs
33
package name=Microsoft.FSharp.VSIX.$(VSSku)
44
version=4.1
55
vs.package.type=vsix
6-
vs.package.language=en-us
6+
vs.package.language=neutral
77

88
vs.dependencies
99
vs.dependency id=Microsoft.FSharp.LangPack.$(VSSku)
1010
version=4.1
11-
type=Required
11+
type=Optional
1212

1313
vs.dependency id=Microsoft.FSharp.Dependencies
1414
version=4.1

0 commit comments

Comments
 (0)