Add Expr.NewStructTuple constructor and active pattern (#8193)

* add Expr.NewStructTuple constructor and active pattern

* update surface areas

Author: eiriktsarpalis

src/fsharp/FSharp.Core/quotations.fs

@@ -391,6 +391,9 @@ module Patterns =
     [<CompiledName("NewTuplePattern")>]
     let (|NewTuple|_|) input = match input with E(CombTerm(NewTupleOp(_), es)) -> Some es | _ -> None
 
+    [<CompiledName("NewStructTuplePattern")>]
+    let (|NewStructTuple|_|) input = match input with E(CombTerm(NewTupleOp(ty), es)) when ty.IsValueType -> Some es | _ -> None
+
     [<CompiledName("DefaultValuePattern")>]
     let (|DefaultValue|_|) input = match input with E(CombTerm(DefaultValueOp ty, [])) -> Some ty | _ -> None
 
@@ -747,6 +750,10 @@ module Patterns =
         let ty = FSharpType.MakeTupleType(Array.map typeOf (Array.ofList args))
         mkFEN (NewTupleOp ty) args
 
+    let mkNewStructTuple (asm, args) =
+        let ty = FSharpType.MakeStructTupleType(asm, Array.map typeOf (Array.ofList args))
+        mkFEN (NewTupleOp ty) args
+
     let mkTupleGet (ty, n, x) =
         checkTypesSR ty (typeOf x) "tupleGet" (SR.GetString(SR.QtmmExprNotMatchTuple))
         let mems = FSharpType.GetTupleElements ty
@@ -1820,6 +1827,9 @@ type Expr with
     static member NewTuple elements =
         mkNewTuple elements
 
+    static member NewStructTuple (asm:Assembly, elements) =
+        mkNewStructTuple (asm, elements)
+
     static member NewRecord (recordType:Type, elements) =
         checkNonNull "recordType" recordType
         mkNewRecord (recordType, elements)

src/fsharp/FSharp.Core/quotations.fsi

@@ -181,6 +181,12 @@ type Expr =
     /// <returns>The resulting expression.</returns>
     static member NewTuple: elements:Expr list -> Expr 
 
+    /// <summary>Builds an expression that represents the creation of an F# tuple value</summary>
+    /// <param name="asm">Runtime assembly containing System.ValueTuple definitions.</param>
+    /// <param name="elements">The list of elements of the tuple.</param>
+    /// <returns>The resulting expression.</returns>
+    static member NewStructTuple: asm:Assembly * elements:Expr list -> Expr 
+
     /// <summary>Builds record-construction expressions </summary>
     /// <param name="recordType">The type of record.</param>
     /// <param name="elements">The list of elements of the record.</param>
@@ -545,6 +551,12 @@ module Patterns =
     [<CompiledName("NewTuplePattern")>]
     val (|NewTuple|_|)        : input:Expr -> (Expr list) option
 
+    /// <summary>An active pattern to recognize expressions that represent construction of struct tuple values</summary>
+    /// <param name="input">The input expression to match against.</param>
+    /// <returns>(Expr list) option</returns>
+    [<CompiledName("NewStructTuplePattern")>]
+    val (|NewStructTuple|_|)        : input:Expr -> (Expr list) option
+
     /// <summary>An active pattern to recognize expressions that represent the read of a static or instance property, or a non-function value declared in a module</summary>
     /// <param name="input">The input expression to match against.</param>
     /// <returns>(Expr option * PropertyInfo * Expr list) option</returns>

src/fsharp/FSharp.Core/reflect.fsi

@@ -314,11 +314,13 @@ type FSharpType =
     static member MakeTupleType: types:Type[] -> Type
 
     /// <summary>Returns a <c>System.Type</c> representing an F# tuple type with the given element types</summary>
+    /// <param name="asm">Runtime assembly containing System.Tuple definitions.</param>
     /// <param name="types">An array of types for the tuple elements.</param>
     /// <returns>The type representing the tuple containing the input elements.</returns>
     static member MakeTupleType: asm:Assembly * types:Type[] -> Type
 
     /// <summary>Returns a <c>System.Type</c> representing an F# struct tuple type with the given element types</summary>
+    /// <param name="asm">Runtime assembly containing System.ValueTuple definitions.</param>
     /// <param name="types">An array of types for the tuple elements.</param>
     /// <returns>The type representing the struct tuple containing the input elements.</returns>
     static member MakeStructTupleType: asm:Assembly * types:Type[] -> Type