Skip to content

Commit e4cc128

Browse files
author
Omar Tawfik
committed
Fix vsix signing
1 parent 7548234 commit e4cc128

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

setup/FSharp.SDK/FSharp.SDK.wixproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
<Import Project="$(WixInstallPath)\wix.targets" />
6464
<Import Project="$(FSharpTreeRoot)\src\Microbuild.Settings.targets" />
6565

66-
<Target Name="CheckLocaleIsPassed" BeforeTargets="Compile">
66+
<Target Name="CheckLocaleIsPassed" BeforeTargets="Build">
6767
<Error Condition="'$(LocaleCode)' == ''" Text="A 'LocaleCode' property must be passed to the project." />
6868
<Error Condition="'$(LocaleId)' == ''" Text="A 'LocaleId' property must be passed to the project." />
6969
<Error Condition="'$(LocaleRegion)' == ''" Text="A 'LocaleRegion' property must be passed to the project." />

setup/Swix/VisualFSharpVSIX/VisualFSharpVSIX.swixproj

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,10 @@
3333
</ItemGroup>
3434

3535
<Target Name="GatherBinariesToBeSigned" AfterTargets="Localize">
36-
<ItemGroup>
37-
<BinariesToBeSigned Include="$(OutDir)\$(OutputName).vsix" />
38-
<FilesToSign Include="@(BinariesToBeSigned)">
39-
<Authenticode>VsixSHA2</Authenticode>
40-
</FilesToSign>
41-
</ItemGroup>
36+
<!-- SWIX plugin adds the built vsix to signing automatically -->
4237
</Target>
4338

44-
<Target Name="CheckPropertiesArePassed" BeforeTargets="Compile">
39+
<Target Name="CheckPropertiesArePassed" BeforeTargets="Build">
4540
<Error Condition="'$(VSSku)' == ''" Text="A 'VSSku' property must be passed to the project." />
4641
<Error Condition="'$(LocaleCode)' == ''" Text="A 'LocaleCode' property must be passed to the project." />
4742
<Error Condition="'$(LocaleId)' == ''" Text="A 'LocaleId' property must be passed to the project." />

0 commit comments

Comments
 (0)