Merge pull request #992 from otawfik-ms/roslyn

Merge latest updates from master

Author: Omar Tawfik

.nuget/NuGet.Config

@@ -10,4 +10,4 @@
     <add key="myget.org roslyn-nightly" value="https://www.myget.org/F/roslyn-nightly" />
     <add key="nuget.org" value="https://www.nuget.org/api/v2/" />  
   </packageSources>  
-</configuration>
+</configuration>

DEVGUIDE.md

@@ -160,7 +160,7 @@ Restart Visual Studio, it should now be running your freshly-built Visual F# IDE
 
 1. The `update.cmd` script adds required strong name validation skips, and NGens the compiler and libraries. This requires admin privileges.
 1. The compiler binaries produced are "private" and strong-named signed with a test key.
-1. Some additional tools are required to build the compiler, notably `fslex.exe`, `fsyacc.exe`, `FSharp.PowerPack.Build.Tasks.dll`, `FsSrGen.exe`, `FSharp.SRGen.Build.Tasks.dll`, and the other tools found in the `lkg` directory.
+1. Some additional tools are required to build the compiler, notably `fslex.exe`, `fsyacc.exe`, `FSharp.PowerPack.Build.Tasks.dll` and the other tools found in the `lkg` directory.
 1. The overall bootstrapping process executes as follows
  - We first need an existing F# compiler. We use the one in the `lkg` directory. Let's assume this compiler has an `FSharp.Core.dll` with version X.
  - We use this compiler to compile the source in this distribution, to produce a "proto" compiler, dropped to the `proto` directory. When run, this compiler still relies on `FSharp.Core.dll` with version X.

lkg/FSharp-14.0.23413.0/bin/FSharp.Core/README.txt

@@ -1,3 +1,3 @@
-The copy of FSharp.Core in this directory is version 2.0.50726.900, required by FSharp.SRGen.Build.Tasks.dll and other legacy Power Pack libraries in the parent directory.
+The copy of FSharp.Core in this directory is version 2.0.50726.900, required by legacy Power Pack libraries in the parent directory.
 
 This copy of FSharp.Core.dll should not be referenced as an LKG, it is present merely as a workaround to enable the legacy libraries to work without needing to update the GAC.

lkg/FSharp-14.0.23413.0/bin/FSharp.SRGen.Build.Tasks.dll

@@ -12,4 +12,6 @@
   <package id="Microsoft.CodeAnalysis.Features" version="1.2.0-beta1-20160218-02" targetFramework="net45" />
   <package id="Microsoft.CodeAnalysis.Workspaces.Common" version="1.2.0-beta1-20160218-02" targetFramework="net45" />
   <package id="Microsoft.VisualStudio.LanguageServices" version="1.2.0-beta1-20160218-02" targetFramework="net46" />
-</packages>
+  <package id="FsSrGen" version="2.0.0" targetFramework="net46" />
+  <package id="FSharp.SRGen.Build.Tasks" version="2.0.0" targetFramework="net46" />
+</packages>

lkg/FSharp-14.0.23413.0/bin/FSharp.SRGen.targets

@@ -115,6 +115,8 @@
 	<MicrosoftCompositionVersion>1.0.30</MicrosoftCompositionVersion>
 	<SystemCollectionsImmutableVersion>1.1.37</SystemCollectionsImmutableVersion>
 	<RoslynVersion>1.2.0-beta1-20160218-02</RoslynVersion>
+    <FsSrGenVersion>2.0.0</FsSrGenVersion>
+    <FsSrGenBuildTasksVersion>2.0.0</FsSrGenBuildTasksVersion>
   </PropertyGroup>
 
   <!-- v2.0-specific flags -->
@@ -710,7 +712,7 @@
 
   <!-- Reference an existing FSI.EXE for use from within MSBuild -->
   <PropertyGroup>
-    <FsSrGenToolPath>$(FSharpSourcesRoot)\..\lkg\FSharp-$(LkgVersion)\bin</FsSrGenToolPath>
+    <FsSrGenToolPath>$(FSharpSourcesRoot)\..\packages\FsSrGen.$(FsSrGenVersion)\lib\net46</FsSrGenToolPath>
     <FsLexToolPath>$(FSharpSourcesRoot)\..\lkg\FSharp-$(LkgVersion)\bin</FsLexToolPath>
     <FsYaccToolPath>$(FSharpSourcesRoot)\..\lkg\FSharp-$(LkgVersion)\bin</FsYaccToolPath>
     <FsLexToolExe>fslex.exe</FsLexToolExe>
@@ -723,7 +725,6 @@
     <CompileDependsOn>ValidateConfiguration;$(CompileDependsOn);CustomCopyLocalFiles</CompileDependsOn>
     <RootNamespace></RootNamespace>
     <DocumentationFile>$(OutputPath)$(AssemblyName).xml</DocumentationFile>
-    <EnsureThereAreNoUnusedFsSrGenResources>false</EnsureThereAreNoUnusedFsSrGenResources>
   </PropertyGroup>
 
   <Target Name="ValidateConfiguration">
@@ -761,7 +762,7 @@
     </CreateItem>
   </Target>
 
-  <Import Project="..\lkg\FSharp-$(LkgVersion)\bin\FSharp.SRGen.targets" />
+  <Import Project="..\packages\FSharp.SRGen.Build.Tasks.$(FsSrGenBuildTasksVersion)\content\FSharp.SRGen.targets" />
 
   <Target Name="ReorderCompileItems"
       BeforeTargets="CoreCompile"

lkg/FSharp-14.0.23413.0/bin/FindUnusedResources.exe

@@ -384,7 +384,7 @@ namespace Microsoft.FSharp.Collections
             checkNonNull "array" array
             let len = array.Length
             let rec loop i = i < len && (f array.[i] || loop (i+1))
-            loop 0
+            len > 0 && loop 0
 
         [<CompiledName("Contains")>]
         let inline contains e (array:'T[]) =