try to fix test: ProjectCracker do not pass project file names as OtherOptions

Author: vasily-kirichenko

src/fsharp/FSharp.Compiler.Service.ProjectCracker/ProjectCracker.fs

@@ -34,7 +34,7 @@ type ProjectCracker =
             logMap := Map.add opts.ProjectFile opts.LogOutput !logMap
             { ProjectFileName = opts.ProjectFile
               ProjectFileNames = sourceFiles
-              OtherOptions = Array.append otherOptions sourceFiles
+              OtherOptions = otherOptions
               ReferencedProjects = referencedProjects
               IsIncompleteTypeCheckEnvironment = false
               UseScriptResolutionRules = false

tests/service/ExprTests.fs

@@ -872,7 +872,7 @@ let ``Check use of type provider that provides calls to F# code`` () =
         |> checker.ParseAndCheckProject 
         |> Async.RunSynchronously
 
-    res.Errors.Length |> shouldEqual 0
+    Assert.AreEqual ([||], res.Errors, sprintf "Should not be errors, but: %A" res.Errors)
 
     let results = 
         [ for f in res.AssemblyContents.ImplementationFiles do