Ensure S3 artifact metadata suffix is not missing content

This commit ensures `suffix` contains whatever is added to the base name.

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>

Author: NotTheEvilOne

src/gardenlinux/s3/s3_artifacts.py

@@ -210,13 +210,11 @@ def upload_from_directory(
                 md5sum = file_digest(fp, "md5").hexdigest()
                 sha256sum = file_digest(fp, "sha256").hexdigest()
 
-            suffixes = "".join(artifact.name)[1 + base_name_length :]
-
             artifact_metadata = {
                 "name": artifact.name,
                 "s3_bucket_name": self._bucket.name,
                 "s3_key": s3_key,
-                "suffix": re_object.sub("+", suffixes),
+                "suffix": re_object.sub("+", artifact.name[base_name_length:]),
                 "md5sum": md5sum,
                 "sha256sum": sha256sum,
             }

tests/s3/constants.py

@@ -33,7 +33,7 @@
 - name: container-amd64-1234.1-abc123lo.release
   s3_bucket_name: test-bucket
   s3_key: objects/container-amd64-1234.1-abc123lo/container-amd64-1234.1-abc123lo.release
-  suffix: release
+  suffix: .release
   md5sum: {md5sum}
   sha256sum: {sha256sum}
 """.strip()