test: align nitpick test conventions

Author: cameroncooke

src/mcp/tools/macos/__tests__/build_run_macos.test.ts

@@ -1,12 +1,9 @@
 import { describe, it, expect, beforeEach } from 'vitest';
-import type { ChildProcess } from 'child_process';
 import * as z from 'zod';
-import { createMockExecutor } from '../../../../test-utils/mock-executors.ts';
+import { createMockExecutor, mockProcess } from '../../../../test-utils/mock-executors.ts';
 import { sessionStore } from '../../../../utils/session-store.ts';
 import tool, { buildRunMacOSLogic } from '../build_run_macos.ts';
 
-const mockProcess = { pid: 12345 } as unknown as ChildProcess;
-
 describe('build_run_macos', () => {
   beforeEach(() => {
     sessionStore.clear();

src/mcp/tools/session-management/__tests__/session_show_defaults.test.ts

@@ -33,6 +33,8 @@ describe('session-show-defaults tool', () => {
     it('should return empty defaults when none set', async () => {
       const result = await plugin.handler();
       expect(result.isError).toBe(false);
+      expect(result.content).toHaveLength(1);
+      expect(typeof result.content[0].text).toBe('string');
       const parsed = JSON.parse(result.content[0].text as string);
       expect(parsed).toEqual({});
     });
@@ -41,6 +43,8 @@ describe('session-show-defaults tool', () => {
       sessionStore.setDefaults({ scheme: 'MyScheme', simulatorId: 'SIM-123' });
       const result = await plugin.handler();
       expect(result.isError).toBe(false);
+      expect(result.content).toHaveLength(1);
+      expect(typeof result.content[0].text).toBe('string');
       const parsed = JSON.parse(result.content[0].text as string);
       expect(parsed.scheme).toBe('MyScheme');
       expect(parsed.simulatorId).toBe('SIM-123');

src/mcp/tools/ui-testing/__tests__/key_press.test.ts

@@ -5,6 +5,7 @@
 import { describe, it, expect, beforeEach } from 'vitest';
 import * as z from 'zod';
 import {
+  createMockCommandResponse,
   createMockExecutor,
   createMockFileSystemExecutor,
   createNoopExecutor,
@@ -81,12 +82,12 @@ describe('Key Press Plugin', () => {
       let capturedCommand: string[] = [];
       const trackingExecutor = async (command: string[]) => {
         capturedCommand = command;
-        return {
+        return createMockCommandResponse({
           success: true,
           output: 'key press completed',
           error: undefined,
           process: mockProcess,
-        };
+        });
       };
 
       const mockAxeHelpers = {
@@ -125,12 +126,12 @@ describe('Key Press Plugin', () => {
       let capturedCommand: string[] = [];
       const trackingExecutor = async (command: string[]) => {
         capturedCommand = command;
-        return {
+        return createMockCommandResponse({
           success: true,
           output: 'key press completed',
           error: undefined,
           process: mockProcess,
-        };
+        });
       };
 
       const mockAxeHelpers = {
@@ -172,12 +173,12 @@ describe('Key Press Plugin', () => {
       let capturedCommand: string[] = [];
       const trackingExecutor = async (command: string[]) => {
         capturedCommand = command;
-        return {
+        return createMockCommandResponse({
           success: true,
           output: 'key press completed',
           error: undefined,
           process: mockProcess,
-        };
+        });
       };
 
       const mockAxeHelpers = {
@@ -216,12 +217,12 @@ describe('Key Press Plugin', () => {
       let capturedCommand: string[] = [];
       const trackingExecutor = async (command: string[]) => {
         capturedCommand = command;
-        return {
+        return createMockCommandResponse({
           success: true,
           output: 'key press completed',
           error: undefined,
           process: mockProcess,
-        };
+        });
       };
 
       const mockAxeHelpers = {