Context
buildDeviceLogic in build_device.ts, build_simLogic in build_sim.ts, and buildMacOSLogic in build_macos.ts are not wrapped in withErrorHandling. If startBuildPipeline or executeXcodeBuildCommand throw an unexpected error (not a build failure, but e.g. a filesystem error), it would propagate unhandled.
The build_run_* variants do use withErrorHandling because they have additional post-build steps. The build-only tools rely on executeXcodeBuildCommand returning error information in buildResult.isError rather than throwing.
Flagged by Sentry bot on PR #325.
Recommendation
Add withErrorHandling wrappers to all three build-only logic functions for consistency and robustness against unexpected throws.
Context
buildDeviceLogicinbuild_device.ts,build_simLogicinbuild_sim.ts, andbuildMacOSLogicinbuild_macos.tsare not wrapped inwithErrorHandling. IfstartBuildPipelineorexecuteXcodeBuildCommandthrow an unexpected error (not a build failure, but e.g. a filesystem error), it would propagate unhandled.The
build_run_*variants do usewithErrorHandlingbecause they have additional post-build steps. The build-only tools rely onexecuteXcodeBuildCommandreturning error information inbuildResult.isErrorrather than throwing.Flagged by Sentry bot on PR #325.
Recommendation
Add
withErrorHandlingwrappers to all three build-only logic functions for consistency and robustness against unexpected throws.