fix(replay): Only set DefaultReplayBreadcrumbConverter if replay is available (#4888)

* Bump Spring Boot 4 to RC2

* Check if replay is available before setting breadcrumbs converter

* changelog

Author: adinauer

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Removed SentryExecutorService limit for delayed scheduled tasks ([#4846](https://github.com/getsentry/sentry-java/pull/4846))
 - Fix visual artifacts for the Canvas strategy on some devices ([#4861](https://github.com/getsentry/sentry-java/pull/4861))
+- Only set `DefaultReplayBreadcrumbConverter` if replay is available ([#4888](https://github.com/getsentry/sentry-java/pull/4888))
 
 ### Improvements
 

sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java

@@ -146,21 +146,24 @@ static void initializeIntegrationsAndProcessors(
       final @NotNull SentryAndroidOptions options,
       final @NotNull Context context,
       final @NotNull io.sentry.util.LoadClass loadClass,
-      final @NotNull ActivityFramesTracker activityFramesTracker) {
+      final @NotNull ActivityFramesTracker activityFramesTracker,
+      final boolean isReplayAvailable) {
     initializeIntegrationsAndProcessors(
         options,
         context,
         new BuildInfoProvider(new AndroidLogger()),
         loadClass,
-        activityFramesTracker);
+        activityFramesTracker,
+        isReplayAvailable);
   }
 
   static void initializeIntegrationsAndProcessors(
       final @NotNull SentryAndroidOptions options,
       final @NotNull Context context,
       final @NotNull BuildInfoProvider buildInfoProvider,
       final @NotNull io.sentry.util.LoadClass loadClass,
-      final @NotNull ActivityFramesTracker activityFramesTracker) {
+      final @NotNull ActivityFramesTracker activityFramesTracker,
+      final boolean isReplayAvailable) {
 
     if (options.getCacheDirPath() != null
         && options.getEnvelopeDiskCache() instanceof NoOpEnvelopeCache) {
@@ -254,8 +257,9 @@ static void initializeIntegrationsAndProcessors(
       options.setCompositePerformanceCollector(new DefaultCompositePerformanceCollector(options));
     }
 
-    if (options.getReplayController().getBreadcrumbConverter()
-        instanceof NoOpReplayBreadcrumbConverter) {
+    if (isReplayAvailable
+        && options.getReplayController().getBreadcrumbConverter()
+            instanceof NoOpReplayBreadcrumbConverter) {
       options
           .getReplayController()
           .setBreadcrumbConverter(new DefaultReplayBreadcrumbConverter(options));

sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java

@@ -171,7 +171,12 @@ public static void init(
             }
 
             AndroidOptionsInitializer.initializeIntegrationsAndProcessors(
-                options, context, buildInfoProvider, loadClass, activityFramesTracker);
+                options,
+                context,
+                buildInfoProvider,
+                loadClass,
+                activityFramesTracker,
+                isReplayAvailable);
 
             deduplicateIntegrations(options, isFragmentAvailable, isTimberAvailable);
           },

sentry-android-core/src/test/java/io/sentry/android/core/AndroidContinuousProfilerTest.kt

@@ -134,6 +134,7 @@ class AndroidContinuousProfilerTest {
       buildInfoProvider,
       loadClass,
       activityFramesTracker,
+      false,
     )
     // Profiler doesn't start if the folder doesn't exists.
     // Usually it's generated when calling Sentry.init, but for tests we can create it manually.

sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt

@@ -117,6 +117,7 @@ class AndroidOptionsInitializerTest {
         if (useRealContext) context else mockContext,
         loadClass,
         activityFramesTracker,
+        false,
       )
     }
 
@@ -162,6 +163,7 @@ class AndroidOptionsInitializerTest {
         buildInfo,
         loadClass,
         activityFramesTracker,
+        isReplayAvailable,
       )
     }
 

sentry-android-core/src/test/java/io/sentry/android/core/AndroidProfilerTest.kt

@@ -136,6 +136,7 @@ class AndroidProfilerTest {
       buildInfoProvider,
       loadClass,
       activityFramesTracker,
+      false,
     )
     // Profiler doesn't start if the folder doesn't exists.
     // Usually it's generated when calling Sentry.init, but for tests we can create it manually.

sentry-android-core/src/test/java/io/sentry/android/core/AndroidTransactionProfilerTest.kt

@@ -152,6 +152,7 @@ class AndroidTransactionProfilerTest {
       buildInfoProvider,
       loadClass,
       activityFramesTracker,
+      false,
     )
     // Profiler doesn't start if the folder doesn't exists.
     // Usually it's generated when calling Sentry.init, but for tests we can create it manually.

sentry-android-core/src/test/java/io/sentry/android/core/SentryInitProviderTest.kt

@@ -168,6 +168,7 @@ class SentryInitProviderTest {
       mockContext,
       loadClass,
       activityFramesTracker,
+      false,
     )
 
     assertFalse(sentryOptions.isEnableNdk)