-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
javascriptPull requests that update javascript codePull requests that update javascript code
Description
Note
The pull request "ref(browser-tests): Add waitForMetricRequest helper" was created by @logaretm but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
Summary
- Adds a shared
waitForMetricRequesthelper to browser integration test utils, following the samepage.waitForRequestpattern aswaitForErrorRequest,waitForTransactionRequest, etc. - Refactors element timing tests to use
waitForMetricRequestinstead of a customcreateMetricCollectorwith polling-basedwaitForIdentifiers - The new helper accumulates
SerializedMetric[]across envelope requests and resolves when the callback returnstruefor the full collected set
Test plan
- Ran element timing tests 5x with
--repeat-each=5— all 10 runs pass consistently
🤖 Generated with Claude Code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
javascriptPull requests that update javascript codePull requests that update javascript code
Fields
Give feedbackNo fields configured for issues without a type.