pick up changes to extraction functions

Author: alexander-alderman-webb

sentry_sdk/ai/_opanai_completions_api.py

@@ -15,16 +15,13 @@ def _is_system_instruction(message: "ChatCompletionMessageParam") -> bool:
     return isinstance(message, dict) and message.get("role") == "system"
 
 
-def _get_system_instructions(
+def _get_system_instructions_completions(
     messages: "Iterable[ChatCompletionMessageParam]",
-) -> "list[ChatCompletionSystemMessageParam]":
-    system_instructions = []
+) -> "list[ChatCompletionMessageParam]":
+    if not isinstance(messages, Iterable):
+        return []
 
-    for message in messages:
-        if _is_system_instruction(message):
-            system_instructions.append(message)
-
-    return system_instructions
+    return [message for message in messages if _is_system_instruction(message)]
 
 
 def _transform_system_instructions(

sentry_sdk/ai/_openai_responses_api.py

@@ -14,16 +14,10 @@ def _is_system_instruction(message: "ResponseInputItemParam") -> bool:
     )
 
 
-def _get_system_instructions(
+def _get_system_instructions_responses(
     messages: "Union[str, ResponseInputParam]",
 ) -> "list[ResponseInputItemParam]":
-    if isinstance(messages, str):
+    if not isinstance(messages, list):
         return []
 
-    system_instructions = []
-
-    for message in messages:
-        if _is_system_instruction(message):
-            system_instructions.append(message)
-
-    return system_instructions
+    return [message for message in messages if _is_system_instruction(message)]