From b2647f3015eeddfee05fead1f93d5b0f7a57d9e7 Mon Sep 17 00:00:00 2001 From: bitsandfoxes Date: Thu, 3 Apr 2025 13:56:15 +0200 Subject: [PATCH 1/2] use unity logger --- src/Sentry.Unity/ScriptableSentryUnityOptions.cs | 2 +- src/Sentry.Unity/SentryUnityOptionsExtensions.cs | 2 +- src/Sentry.Unity/SentryUnitySDK.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Sentry.Unity/ScriptableSentryUnityOptions.cs b/src/Sentry.Unity/ScriptableSentryUnityOptions.cs index f1de21f54..6cb2a7ce9 100644 --- a/src/Sentry.Unity/ScriptableSentryUnityOptions.cs +++ b/src/Sentry.Unity/ScriptableSentryUnityOptions.cs @@ -224,7 +224,7 @@ internal SentryUnityOptions ToSentryUnityOptions(bool isBuilding, ISentryUnityIn // We need to set up logging here because the configure callback might have changed the debug options. // Without setting up here we might miss out on logs between option-loading (now) and Init - i.e. native configuration - options.SetupLogging(); + options.SetupUnityLogging(); if (options.AttachViewHierarchy) { diff --git a/src/Sentry.Unity/SentryUnityOptionsExtensions.cs b/src/Sentry.Unity/SentryUnityOptionsExtensions.cs index c444c42c5..773e45391 100644 --- a/src/Sentry.Unity/SentryUnityOptionsExtensions.cs +++ b/src/Sentry.Unity/SentryUnityOptionsExtensions.cs @@ -47,7 +47,7 @@ internal static bool IsValid(this SentryUnityOptions options) return true; } - internal static void SetupLogging(this SentryUnityOptions options) + internal static void SetupUnityLogging(this SentryUnityOptions options) { if (options.Debug) { diff --git a/src/Sentry.Unity/SentryUnitySDK.cs b/src/Sentry.Unity/SentryUnitySDK.cs index 419a8e8d0..029e34194 100644 --- a/src/Sentry.Unity/SentryUnitySDK.cs +++ b/src/Sentry.Unity/SentryUnitySDK.cs @@ -22,7 +22,7 @@ private SentryUnitySdk(SentryUnityOptions options) { var unitySdk = new SentryUnitySdk(options); - options.SetupLogging(); + options.SetupUnityLogging(); if (!options.ShouldInitializeSdk()) { return null; From 439eee34a53d1f56cc5689e59cc431d79f1bcc0a Mon Sep 17 00:00:00 2001 From: bitsandfoxes Date: Thu, 3 Apr 2025 14:04:11 +0200 Subject: [PATCH 2/2] tests --- .../Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs b/test/Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs index 226ad0a03..4da6d173f 100644 --- a/test/Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs +++ b/test/Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs @@ -99,7 +99,7 @@ public void SetupLogging_DebugAndNoDiagnosticLogger_SetsUnityLogger() Assert.IsNull(options.DiagnosticLogger); // Sanity check - options.SetupLogging(); + options.SetupUnityLogging(); Assert.IsInstanceOf(options.DiagnosticLogger); } @@ -111,7 +111,7 @@ public void SetupLogging_DebugFalse_DiagnosticLoggerIsNull() var options = _fixture.GetSut(); options.DiagnosticLogger = new UnityLogger(options); - options.SetupLogging(); + options.SetupUnityLogging(); Assert.IsNull(options.DiagnosticLogger); } @@ -125,7 +125,7 @@ public void SetupLogging_DiagnosticLoggerSet_LeavesOrRemovesDiagnosticLogger(boo var options = _fixture.GetSut(); options.DiagnosticLogger = new UnityLogger(options); - options.SetupLogging(); + options.SetupUnityLogging(); Assert.AreEqual(debug, options.DiagnosticLogger is not null); }