From 37d2053bb3969b8c957a12cd6b96ad41ba391c11 Mon Sep 17 00:00:00 2001 From: Colleen O'Rourke Date: Tue, 12 May 2026 15:33:39 -0700 Subject: [PATCH] chore(alerts): Remove triggerd_incidents from AlertRuleTrigger --- migrations_lockfile.txt | 2 +- src/sentry/incidents/models/alert_rule.py | 4 --- ...rm_triggered_incidents_alertruletrigger.py | 34 +++++++++++++++++++ 3 files changed, 35 insertions(+), 5 deletions(-) create mode 100644 src/sentry/migrations/1090_rm_triggered_incidents_alertruletrigger.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 5f0830b5206dd4..f31f1dacf47a9f 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -31,7 +31,7 @@ replays: 0007_organizationmember_replay_access seer: 0011_add_project_repository_fk_to_seer -sentry: 1089_drop_rulefirehistory +sentry: 1090_rm_triggered_incidents_alertruletrigger social_auth: 0003_social_auth_json_field diff --git a/src/sentry/incidents/models/alert_rule.py b/src/sentry/incidents/models/alert_rule.py index 02b55a71157dfb..6e497ed1a32dd3 100644 --- a/src/sentry/incidents/models/alert_rule.py +++ b/src/sentry/incidents/models/alert_rule.py @@ -26,7 +26,6 @@ from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey from sentry.db.models.manager.base import BaseManager from sentry.db.models.manager.base_query_set import BaseQuerySet -from sentry.incidents.models.incident import IncidentTrigger from sentry.models.organization import Organization from sentry.models.organizationmember import OrganizationMember from sentry.models.project import Project @@ -305,9 +304,6 @@ class AlertRuleTrigger(Model): threshold_type = models.SmallIntegerField(null=True) alert_threshold = models.FloatField() resolve_threshold = models.FloatField(null=True) - triggered_incidents = models.ManyToManyField( - "sentry.Incident", related_name="triggers", through=IncidentTrigger - ) date_added = models.DateTimeField(default=timezone.now) objects: ClassVar[AlertRuleTriggerManager] = AlertRuleTriggerManager() diff --git a/src/sentry/migrations/1090_rm_triggered_incidents_alertruletrigger.py b/src/sentry/migrations/1090_rm_triggered_incidents_alertruletrigger.py new file mode 100644 index 00000000000000..526841f2740ef6 --- /dev/null +++ b/src/sentry/migrations/1090_rm_triggered_incidents_alertruletrigger.py @@ -0,0 +1,34 @@ +# Generated by Django 5.2.14 on 2026-05-12 22:30 + + +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.fields import SafeRemoveField +from sentry.new_migrations.monkey.state import DeletionAction + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "1089_drop_rulefirehistory"), + ] + + operations = [ + SafeRemoveField( + model_name="alertruletrigger", + name="triggered_incidents", + deletion_action=DeletionAction.MOVE_TO_PENDING, + ), + ]