Skip to content

Commit d2a1beb

Browse files
committed
fix: Comment out failing new workflows
The earlier series of commits adds the address and thread sanitizer to the dev workflows. These fail due to real bugs that need to be addressed. However, that is for later commits. While the sanitizer jobs are marked as optional and do not cause build failure, the summary job still sees them as failed and fails. A future commit should make the summary job somehow look at the optional flag and not fail.
1 parent 10b74af commit d2a1beb

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

.github/workflows/dev.yml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,20 @@ jobs:
135135
profile: "release"
136136
sanitize: "" # TODO: enable safe-stack,cfi when possible
137137
instrument: "none"
138-
- name: "sanitize/address"
139-
profile: "debug" # FIXME: should be fuzz, but build time explodes for unknown reasons
140-
sanitize: "address"
141-
instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
142-
optional: true # FIXME: Make required once existing bugs are fixed
143-
- name: "sanitize/thread"
144-
profile: "fuzz"
145-
sanitize: "thread"
146-
instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
147-
optional: true # FIXME: Make required once existing bugs are fixed
138+
# FIXME: The following commented sections are marked optional
139+
# and the build continues after they fail, but then summary
140+
# fails. For now, comment this out, but ideally we'd run them
141+
# let them fail, but let the summary pass anyway
142+
# - name: "sanitize/address"
143+
# profile: "debug" # FIXME: should be fuzz, but build time explodes for unknown reasons
144+
# sanitize: "address"
145+
# instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
146+
# optional: true # FIXME: Make required once existing bugs are fixed
147+
# - name: "sanitize/thread"
148+
# profile: "fuzz"
149+
# sanitize: "thread"
150+
# instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
151+
# optional: true # FIXME: Make required once existing bugs are fixed
148152
debug_justfile:
149153
- "${{ inputs.debug_justfile || false }}"
150154
steps:

0 commit comments

Comments
 (0)