From 1373f1f5c9100b7b2da0e0bd2432518ac5eaca7a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 17 Oct 2025 08:05:37 +0000 Subject: [PATCH 1/3] Initial plan From 80f8fb8bc7098c204bafb74a08be1aa2df6112d6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 17 Oct 2025 08:08:47 +0000 Subject: [PATCH 2/3] Update PR template to require test coverage or justification Co-authored-by: oscarsj <1410188+oscarsj@users.noreply.github.com> --- .github/pull_request_template.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3b632d8f37..8ebe73aebd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -29,13 +29,16 @@ For internal use only. Please select the risk level of this change: #### How did/will you validate this change? - + - **Test repository** - This change will be tested on a test repository before merging. -- **Unit tests** - I am depending on unit test coverage (i.e. tests in `.test.ts` files). +- **Unit tests** - I am depending on existing unit test coverage (i.e. tests in `.test.ts` files). - **End-to-end tests** - I am depending on PR checks (i.e. tests in `pr-checks`). +- **New / updated tests** - I have added or updated unit / end-to-end tests to cover new or changed functionality (summarize below) OR I am providing a justification below for why test updates are not required. - **Other** - Please provide details. -- **None** - I am not validating these changes. +- **None** - I am not validating these changes (provide justification below). + + #### If something goes wrong after this change is released, what are the mitigation and rollback strategies? @@ -57,5 +60,6 @@ For internal use only. Please select the risk level of this change: ### Merge / deployment checklist - Confirm this change is backwards compatible with existing workflows. +- Tests (unit and/or end-to-end) have been added or updated as needed and are passing, OR a justification for not adding tests has been provided. - Consider adding a [changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) entry for this change. - Confirm the [readme](https://github.com/github/codeql-action/blob/main/README.md) and docs have been updated if necessary. From fa793767180dea0d49a449232d225db954654bd6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 17 Oct 2025 09:29:41 +0000 Subject: [PATCH 3/3] Make PR template more concise Co-authored-by: oscarsj <1410188+oscarsj@users.noreply.github.com> --- .github/pull_request_template.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8ebe73aebd..a956e5656a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -29,17 +29,15 @@ For internal use only. Please select the risk level of this change: #### How did/will you validate this change? - + - **Test repository** - This change will be tested on a test repository before merging. - **Unit tests** - I am depending on existing unit test coverage (i.e. tests in `.test.ts` files). - **End-to-end tests** - I am depending on PR checks (i.e. tests in `pr-checks`). -- **New / updated tests** - I have added or updated unit / end-to-end tests to cover new or changed functionality (summarize below) OR I am providing a justification below for why test updates are not required. +- **New / updated tests** - I have added or updated tests (summarize below). - **Other** - Please provide details. - **None** - I am not validating these changes (provide justification below). - - #### If something goes wrong after this change is released, what are the mitigation and rollback strategies? @@ -60,6 +58,6 @@ For internal use only. Please select the risk level of this change: ### Merge / deployment checklist - Confirm this change is backwards compatible with existing workflows. -- Tests (unit and/or end-to-end) have been added or updated as needed and are passing, OR a justification for not adding tests has been provided. +- Confirm that tests have been added/updated or are not needed. - Consider adding a [changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) entry for this change. - Confirm the [readme](https://github.com/github/codeql-action/blob/main/README.md) and docs have been updated if necessary.