Copilot feedback

Author: MichaelRFairhurst

cpp/common/src/codingstandards/cpp/ast/HiddenFriend.qll

@@ -82,7 +82,7 @@ private class ClassCandidate extends Class {
    */
   Declaration getNextOrphanedDeclaration() {
     result =
-      min(OrphanedDeclaration decl, int startLine, int startColumn | // Location locDecl | // Location locLast, Location locDecl |
+      min(OrphanedDeclaration decl, int startLine, int startColumn |
         orphanHasLocation(decl, this.getFile(), startLine, startColumn) and
         startLine > getLastLineOfClassDeclaration(this)
       |
@@ -109,11 +109,11 @@ private class ClassCandidate extends Class {
  */
 pragma[nomagic]
 private predicate orphanHasLocation(
-  OrphanedDeclaration orphan, FileCandidate file, int endLine, int endColumn
+  OrphanedDeclaration orphan, FileCandidate file, int startLine, int startColumn
 ) {
   orphan.getFile() = file and
-  orphan.getLocation().getEndLine() = endLine and
-  orphan.getLocation().getEndColumn() = endColumn
+  orphan.getLocation().getEndLine() = startLine and
+  orphan.getLocation().getEndColumn() = startColumn
 }
 
 /**

cpp/misra/test/rules/RULE-0-2-3/templates.cpp

@@ -86,7 +86,7 @@ namespace use_as_template_parameter_type {
 } // namespace use_as_template_parameter_type
 
 /**
- * Test case 6: A type that is used as the default value of a non-type template
+ * Test case 7: A type that is used as the default value of a non-type template
  * parameter
  */
 namespace use_as_template_parameter_default_value {