Skip to content

Commit cf6f60c

Browse files
authored
Merge pull request #1057 from github/michaelrfairhurst/fix-path-problem-nodes-from-outside-workspace
Fix path problem locations in .expected for 8-1-1, 8-1-2
2 parents 1005c67 + d2d8d6b commit cf6f60c

File tree

5 files changed

+400
-331
lines changed

5 files changed

+400
-331
lines changed

.github/copilot-instructions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,6 @@ When reviewing tests, it is critical to:
5555
- Check that there are no `.expected` rows that refer to test code cases marked as `COMPLIANT`, or with no comment
5656
- Note that it is OK if the locations of the comment are not precisely aligned with the alert
5757
- Check that the alert message and placeholders are accurate and understandable.
58+
- Check that the locations do not refer to files in the standard library, as these have issues in GitHub's Code Scanning UI and complicate our compiler compatibility tests.
5859
- Consider the "test coverage" of the query, are each of its logical statements effectively exercised individually, collectively? The test should neither be overly bloated nor under specified.
5960
- Consider the edge cases of the language itself, will the analysis work in non-trivial cases, are all relevant language concepts tested here? This doesn't need to be exhaustive, but it should be thoughfully thorough.

0 commit comments

Comments
 (0)