Skip to content

Commit 2da6b5a

Browse files
Copilotedburns
andauthored
Fix code review issues: duplicate assertion, copyright header, Javadoc example
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/16d575c4-83f4-4d20-99d9-b48635b3791d Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent 4001135 commit 2da6b5a

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/main/java/com/github/copilot/sdk/json/GetSessionMetadataResponse.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/*---------------------------------------------------------------------------------------------
2+
* Copyright (c) Microsoft Corporation. All rights reserved.
3+
*--------------------------------------------------------------------------------------------*/
4+
15
package com.github.copilot.sdk.json;
26

37
import com.fasterxml.jackson.annotation.JsonInclude;

src/main/java/com/github/copilot/sdk/json/SessionUiApi.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
* <h2>Example Usage</h2>
1919
*
2020
* <pre>{@code
21-
* if (Boolean.TRUE
22-
* .equals(session.getCapabilities().getUi() != null && session.getCapabilities().getUi().getElicitation())) {
21+
* var caps = session.getCapabilities();
22+
* if (caps.getUi() != null && Boolean.TRUE.equals(caps.getUi().getElicitation())) {
2323
* boolean confirmed = session.getUi().confirm("Are you sure?").get();
2424
* }
2525
* }</pre>

src/test/java/com/github/copilot/sdk/ElicitationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ void sessionCapabilitiesTypesAreProperlyStructured() {
4444
// Test with null UI
4545
var emptyCapabilities = new SessionCapabilities();
4646
assertNull(emptyCapabilities.getUi());
47-
assertNull(emptyCapabilities.getUi());
4847
}
4948

5049
@Test

0 commit comments

Comments
 (0)