Repo-renaming bug exists in v2.1.18

[dolan-a]

Problem Description

When I run safe-settings with the latest release (v2.1.18), the repo PATCHes return an error about "name already exists on this account" because it is trying to rename all of my repos to one of the other repos in my org.

An earlier PR (#795) addressed this issue, and I finally gave the latest version a try today without my workaround noted here, and now the error is back.

I see that a later PR (#806) reverted the change. I don't know if this was intentional or not, but I'm able to get around the issue by re-adding my patch:

# patching https://github.com/github/safe-settings/blob/2.1.18/lib/settings.js#L334
sed -i "334s/assign(repoConfig/assign({}, repoConfig/" ./lib/settings.js

What is actually happening

Safe-settings won't run correctly without this change

What is the expected behavior

Safe-settings is able to patch repos

Error output, if available

{"message":"Validation Failed","errors":[{"resource":"Repository","code":"custom","field":"name","message":"name already exists on this account"}],"documentation_url":"https://docs.github.com/rest/repos/repos#update-a-repository","status":"422"}}

Context

Are you using the hosted instance of probot/settings or running your own?

self-run via GHA

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

n/a

Version of GitHub Enterprise

n/a

[brianespinosa]

I just updated today from 2.1.17 and noticed this same issue. I notice you're also running safe-settings in a GitHub Action. I wonder if this problem is specific to running this way?