From 7294480a9194ab44d7074e9edd1b6e0bd4e3d48d Mon Sep 17 00:00:00 2001 From: Nora Date: Mon, 3 Mar 2025 11:03:54 +0000 Subject: [PATCH 1/2] Add expected http error to code search test plan --- docs/test-plan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/test-plan.md b/docs/test-plan.md index b5441f60b54..c3103999d7b 100644 --- a/docs/test-plan.md +++ b/docs/test-plan.md @@ -490,7 +490,7 @@ This requires running a MRVA query and seeing the results view. 1. Make changes via config file (ensure JSON schema is helping out) 1. Close and re-open VS Code (ensure lists are there) 1. Collapse/expand tree nodes -1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This should show a rate limiting notification after a while but eventually populate the list with roughly 770 items. +1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. Error cases that trigger an error notification: From f201a88babb1d1004dcd63d455caf44ed3effc62 Mon Sep 17 00:00:00 2001 From: Nora Date: Mon, 3 Mar 2025 13:36:03 +0000 Subject: [PATCH 2/2] Merge comments --- docs/test-plan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/test-plan.md b/docs/test-plan.md index c3103999d7b..904dda61b4c 100644 --- a/docs/test-plan.md +++ b/docs/test-plan.md @@ -490,7 +490,7 @@ This requires running a MRVA query and seeing the results view. 1. Make changes via config file (ensure JSON schema is helping out) 1. Close and re-open VS Code (ensure lists are there) 1. Collapse/expand tree nodes -1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. +1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when it is run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. Error cases that trigger an error notification: