From 0a55f024a9a93226bd3d4b62f4643cec2fa6402c Mon Sep 17 00:00:00 2001 From: Charis Kyriakou Date: Tue, 12 Aug 2025 10:31:24 +0000 Subject: [PATCH] Remove support for CodeQL CLI versions older than v2.19.4 --- extensions/ql-vscode/CHANGELOG.md | 1 + extensions/ql-vscode/src/codeql-cli/cli.ts | 2 +- extensions/ql-vscode/supported_cli_versions.json | 1 - .../vscode-tests/cli-integration/debugger/debugger.test.ts | 6 ------ 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 3ff85de5196..0b3c1bfb4c2 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -3,6 +3,7 @@ ## [UNRELEASED] - Add new command "CodeQL: Trim Overlay Base Cache" that returns a database to the state prior to overlay evaluation, leaving only base predicates and types that may later be referenced during overlay evaluation. [#4082](https://github.com/github/vscode-codeql/pull/4082) +- Remove support for CodeQL CLI versions older than 2.19.4. [#4108](https://github.com/github/vscode-codeql/pull/4108) ## 1.17.4 - 10 July 2025 diff --git a/extensions/ql-vscode/src/codeql-cli/cli.ts b/extensions/ql-vscode/src/codeql-cli/cli.ts index fbb0038a694..1ef1e4a8d40 100644 --- a/extensions/ql-vscode/src/codeql-cli/cli.ts +++ b/extensions/ql-vscode/src/codeql-cli/cli.ts @@ -1902,7 +1902,7 @@ function shouldDebugCliServer() { export class CliVersionConstraint { // The oldest version of the CLI that we support. This is used to determine // whether to show a warning about the CLI being too old on startup. - public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.18.4"); + public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.19.4"); constructor(private readonly cli: CodeQLCliServer) { /**/ diff --git a/extensions/ql-vscode/supported_cli_versions.json b/extensions/ql-vscode/supported_cli_versions.json index d554fe40aee..0c955173959 100644 --- a/extensions/ql-vscode/supported_cli_versions.json +++ b/extensions/ql-vscode/supported_cli_versions.json @@ -3,6 +3,5 @@ "v2.21.4", "v2.20.7", "v2.19.4", - "v2.18.4", "nightly" ] diff --git a/extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts b/extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts index 76509030a4e..0230bf996f0 100644 --- a/extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts +++ b/extensions/ql-vscode/test/vscode-tests/cli-integration/debugger/debugger.test.ts @@ -157,12 +157,6 @@ describeWithCodeQL()("Debugger", () => { it("should run a quick evaluation with a bigint-valued result column", async () => { await withDebugController(appCommands, async (controller) => { - const semver = await cli.getVersion(); - if (semver.compare("2.18.4") < 0) { - // Skip this test if the CLI version is too old to support BigInt - return; - } - await selectForQuickEval(quickEvalBigIntQueryPath, 4, 23, 4, 37); // Don't specify a query path, so we'll default to the active document ("QuickEvalBigIntQuery.ql")