From eb656a2ab5b972450768ff0a9751dbd0768eb94b Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 30 Oct 2025 20:37:59 +0000
Subject: [PATCH 1/4] Initial plan


From f1efdd3f27947c865e9ec566231b4e8bc496b715 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 30 Oct 2025 20:48:33 +0000
Subject: [PATCH 2/4] Update eslint-plugin-react-hooks configuration for flat
 config format

Co-authored-by: cklin <1418580+cklin@users.noreply.github.com>
---
 extensions/ql-vscode/eslint.config.mjs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/extensions/ql-vscode/eslint.config.mjs b/extensions/ql-vscode/eslint.config.mjs
index e453a1f9838..9ab28ecd61b 100644
--- a/extensions/ql-vscode/eslint.config.mjs
+++ b/extensions/ql-vscode/eslint.config.mjs
@@ -113,7 +113,7 @@ export default tseslint.config(
     extends: [
       react.configs.flat.recommended,
       react.configs.flat['jsx-runtime'],
-      reactHooks.configs['recommended-latest'],
+      reactHooks.configs.flat['recommended-latest'],
       storybook.configs['flat/recommended'],
       github.getFlatConfigs().react,
     ],
@@ -133,7 +133,7 @@ export default tseslint.config(
     extends: [
       react.configs.flat.recommended,
       react.configs.flat['jsx-runtime'],
-      reactHooks.configs['recommended-latest'],
+      reactHooks.configs.flat['recommended-latest'],
       github.getFlatConfigs().react,
     ],
     settings: {

From e7a4e4bad5c1ce4c36b6459a723be07cd3ef3ff3 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 30 Oct 2025 21:06:38 +0000
Subject: [PATCH 3/4] Fix eslint-plugin-react-hooks 7.0.1 linting issues

Co-authored-by: cklin <1418580+cklin@users.noreply.github.com>
---
 extensions/ql-vscode/eslint.config.mjs | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/extensions/ql-vscode/eslint.config.mjs b/extensions/ql-vscode/eslint.config.mjs
index 9ab28ecd61b..c93d79cfa1c 100644
--- a/extensions/ql-vscode/eslint.config.mjs
+++ b/extensions/ql-vscode/eslint.config.mjs
@@ -122,6 +122,13 @@ export default tseslint.config(
         version: "detect",
       },
     },
+    rules: {
+      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1
+      "react-hooks/set-state-in-effect": "off",
+      "react-hooks/refs": "off",
+      "react-hooks/purity": "off",
+      "react-hooks/error-boundaries": "off",
+    },
   },
   {
     files: ["src/view/**/*"],
@@ -141,6 +148,24 @@ export default tseslint.config(
         version: "detect",
       },
     },
+    rules: {
+      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1
+      "react-hooks/set-state-in-effect": "off",
+      "react-hooks/refs": "off",
+      "react-hooks/purity": "off",
+      "react-hooks/error-boundaries": "off",
+    },
+  },
+  {
+    // Special case for files using custom useEffectEvent implementation
+    files: [
+      "src/view/common/SuggestBox/useOpenKey.ts",
+      "src/view/common/SuggestBox/__tests__/useEffectEvent.test.ts",
+    ],
+    rules: {
+      "react-hooks/rules-of-hooks": "off",
+      "react-hooks/exhaustive-deps": "off",
+    },
   },
   {
     files: ["test/vscode-tests/**/*"],

From b2393daaf885c0bdbf1b5773aabbef2e8e8a7b50 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 30 Oct 2025 21:39:13 +0000
Subject: [PATCH 4/4] Only disable strict rules that actually fail with current
 codebase

Co-authored-by: cklin <1418580+cklin@users.noreply.github.com>
---
 extensions/ql-vscode/eslint.config.mjs | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/extensions/ql-vscode/eslint.config.mjs b/extensions/ql-vscode/eslint.config.mjs
index c93d79cfa1c..96f86a7c6ff 100644
--- a/extensions/ql-vscode/eslint.config.mjs
+++ b/extensions/ql-vscode/eslint.config.mjs
@@ -123,11 +123,8 @@ export default tseslint.config(
       },
     },
     rules: {
-      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1
+      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1 that fail with current codebase
       "react-hooks/set-state-in-effect": "off",
-      "react-hooks/refs": "off",
-      "react-hooks/purity": "off",
-      "react-hooks/error-boundaries": "off",
     },
   },
   {
@@ -149,7 +146,7 @@ export default tseslint.config(
       },
     },
     rules: {
-      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1
+      // Disable new strict rules from eslint-plugin-react-hooks 7.0.1 that fail with current codebase
       "react-hooks/set-state-in-effect": "off",
       "react-hooks/refs": "off",
       "react-hooks/purity": "off",