Skip to content

Commit dbe5249

Browse files
authored
Merge pull request #160 from githubdoe/mirror_config_bug
Mirror config bug
2 parents 920c841 + 164269b commit dbe5249

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

RevisionHistory.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@
409409
</ul>
410410
</ul>
411411

412-
<ul><li>Version 7.2.2</li>
412+
<ul><li>Version 7.2.3</li>
413413
<ul>
414414
<li>Improved DLL dependencies behavior for developers</li>
415415
<li>Fixed a bug in mirror config when switching between inch and millimeter</li>

mirrordlg.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,10 @@ void mirrorDlg::loadFile(QString & fileName){
305305
m_verticalAxis = QJsonValue(Ellipse["ellipse vert axis"]).toDouble();
306306
QJsonObject Annulus = loadDoc["Annulus"].toObject();
307307
m_useAnnular = QJsonValue(Annulus["use annular Zernike values"]).toBool();
308-
m_annularObsPercent = QJsonValue(Annulus["obs percentage"]).toDouble() * 100.;
308+
m_annularObsPercent = QJsonValue(Annulus["obs percentage"]).toDouble();
309309
ui->useAnnulus->setChecked(m_useAnnular);
310-
ui->annulusPercent->setValue(m_annularObsPercent);
311-
on_annulusPercent_valueChanged(m_annularObsPercent);
310+
ui->annulusPercent->setValue(m_annularObsPercent * 100);
311+
on_annulusPercent_valueChanged(m_annularObsPercent * 100);
312312
enableAnnular(m_useAnnular);
313313

314314
ui->fringeSpacingEdit->blockSignals(true);

mirrordlg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class mirrorDlg : public QDialog
5353
bool fliph;
5454
bool m_useAnnular;
5555
bool m_connectAnnulusToObs;
56-
double m_annularObsPercent;
56+
double m_annularObsPercent; // a value from 0 to 1 (not 0 to 100)
5757
double m_clearAperature;
5858
double aperatureReduction;
5959
static QString m_projectPath;

0 commit comments

Comments
 (0)