Set :name metadata on vars

jfhamlin · jfhamlin · commit 4e9214a63f33 · 2025-09-27T13:49:12.000-07:00
Signed-off-by: James Hamlin &lt;jfhamlin@gmail.com&gt;
diff --git a/pkg/lang/var.go b/pkg/lang/var.go
@@ -100,7 +100,8 @@ func NewVar(ns *Namespace, sym *Symbol) *Var {
 		watches: emptyMap,
 	}
 	v.root.Store(Box{val: &UnboundVar{v: v}})
-	v.meta.Store(NewBox(emptyMap))
+	v.meta.Store(NewBox(emptyMap)) // Initialize for SetMeta to work
+	v.SetMeta(emptyMap) // This will add :name and :ns metadata
 	return v
 }
 
@@ -167,6 +168,8 @@ func (v *Var) Meta() IPersistentMap {
 
 func (v *Var) SetMeta(meta IPersistentMap) {
 	// TODO: ResetMeta
+	// Ensure these basis keys (matching Clojure's Var.java)
+	meta = Assoc(meta, KWName, v.sym).(IPersistentMap)
 	meta = Assoc(meta, KWNS, v.ns).(IPersistentMap)
 	v.meta.Store(NewBox(meta))
 }

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,8 @@ func NewVar(ns Namespace, sym Symbol) *Var {`
`100`	`100`	`watches: emptyMap,`
`101`	`101`	`}`
`102`	`102`	`v.root.Store(Box{val: &UnboundVar{v: v}})`
`103`		`- v.meta.Store(NewBox(emptyMap))`
	`103`	`+ v.meta.Store(NewBox(emptyMap)) // Initialize for SetMeta to work`
	`104`	`+ v.SetMeta(emptyMap) // This will add :name and :ns metadata`
`104`	`105`	`return v`
`105`	`106`	`}`
`106`	`107`
`@@ -167,6 +168,8 @@ func (v *Var) Meta() IPersistentMap {`
`167`	`168`
`168`	`169`	`func (v *Var) SetMeta(meta IPersistentMap) {`
`169`	`170`	`// TODO: ResetMeta`
	`171`	`+ // Ensure these basis keys (matching Clojure's Var.java)`
	`172`	`+ meta = Assoc(meta, KWName, v.sym).(IPersistentMap)`
`170`	`173`	`meta = Assoc(meta, KWNS, v.ns).(IPersistentMap)`
`171`	`174`	`v.meta.Store(NewBox(meta))`
`172`	`175`	`}`