Add more sort-by tests

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

Author: jfhamlin

pkg/lang/slices.go

@@ -15,12 +15,12 @@ func ToSlice(x any) []any {
 	if IsNil(x) {
 		return []any{}
 	}
-	
+
 	// Handle []any - return as-is
 	if slice, ok := x.([]any); ok {
 		return slice
 	}
-	
+
 	// Handle IPersistentVector
 	if vec, ok := x.(IPersistentVector); ok {
 		count := vec.Count()
@@ -30,7 +30,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Handle IPersistentMap - convert to array of MapEntry objects
 	if m, ok := x.(IPersistentMap); ok {
 		seq := m.Seq()
@@ -41,7 +41,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Handle Set - convert to array of values
 	if s, ok := x.(*Set); ok {
 		seq := s.Seq()
@@ -52,7 +52,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Handle string - convert to character array
 	if s, ok := x.(string); ok {
 		runes := []rune(s) // Important: use runes for proper Unicode handling
@@ -62,7 +62,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Handle ISeq
 	if s, ok := x.(ISeq); ok {
 		res := make([]interface{}, 0, Count(x))
@@ -71,7 +71,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Handle reflection-based slice/array
 	xVal := reflect.ValueOf(x)
 	if xVal.Kind() == reflect.Slice || xVal.Kind() == reflect.Array {
@@ -81,7 +81,7 @@ func ToSlice(x any) []any {
 		}
 		return res
 	}
-	
+
 	// Error with Clojure-style message
 	panic(NewIllegalArgumentError(fmt.Sprintf("Unable to convert: %T to Object[]", x)))
 }

pkg/lang/subvector.go

@@ -171,17 +171,17 @@ func (v *SubVector) Compare(other any) int {
 	if !ok {
 		panic(NewIllegalArgumentError(fmt.Sprintf("Cannot compare SubVector with %T", other)))
 	}
-	
+
 	myCount := v.Count()
 	otherCount := otherVec.Count()
-	
+
 	// Compare lengths first
 	if myCount < otherCount {
 		return -1
 	} else if myCount > otherCount {
 		return 1
 	}
-	
+
 	// Compare element by element
 	for i := 0; i < myCount; i++ {
 		cmp := Compare(v.Nth(i), otherVec.Nth(i))

test/glojure/test_glojure/sort.glj

@@ -11,6 +11,7 @@
     (is (= '(1 2 3 4 5) (sort [3 1 4 2 5])))
     (is (= '(1 1 3 4 5) (sort [3 1 4 1 5]))) ; duplicates preserved
     (is (= '(1.0 2.5 3 4.7) (sort [4.7 1.0 3 2.5]))) ; mixed numeric types
+    (is (= '(-5 0 1.5 2 3.14 10) (sort [3.14 2 1.5 10 -5 0])))
 
     ;; Strings
     (is (= '("apple" "banana" "cherry") (sort ["cherry" "apple" "banana"])))
@@ -251,5 +252,40 @@
     (is (= -1 (compare 'ns/a 'ns/b)))
     (is (= 1 (compare 'ns/b 'ns/a)))))
 
+(deftest sort-by-clojuredocs-examples
+  (testing "Examples from ClojureDocs sort-by documentation"
+
+    (let [words ["banana" "apple" "cherry" "date"]]
+      (is (= '("date" "apple"  "banana" "cherry")
+             (sort-by count words))))
+
+    (let [words ["banana" "apple" "cherry" "date"]]
+      (is (= (sort-by count > words)
+             '("banana" "cherry" "apple" "date"))))
+
+    (let [people [{:name "Alice" :age 30 :city "NYC"}
+                  {:name "Bob" :age 25 :city "LA"}
+                  {:name "Charlie" :age 35 :city "NYC"}
+                  {:name "David" :age 25 :city "LA"}]]
+      (is (= (sort-by (juxt :city :age) people)
+             '({:name "Bob" :age 25 :city "LA"}
+               {:name "David" :age 25 :city "LA"}
+               {:name "Alice" :age 30 :city "NYC"}
+               {:name "Charlie" :age 35 :city "NYC"}))))
+
+    (let [numbers [3 1 4 1 5 9 2 6]]
+      (is (= '(3 9 6 1 4 1 5 2)
+             (sort-by #(mod % 3) numbers))))
+
+    (let [items [nil "hello" 42 :keyword]]
+      (is (= (sort-by str items)
+             '(nil 42 :keyword "hello"))))
+
+    (is (= (sort-by identity []) '()))
+    (is (= (sort-by count []) '()))
+
+    (is (= (sort-by identity [42]) '(42)))
+    (is (= (sort-by count ["hello"]) '("hello")))))
+
 ;; Run tests
 (run-tests)