Add support for reader conditionals (#? and #?@) (#109)

* Add reader support for shebang-style comments

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

* Basic support of reader conditionals

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

* Handle reader conditionals at EOF or end of collections

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

* Add more reader conditional tests

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

* Reader fixes after fuzz testing runs

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

---------

Signed-off-by: James Hamlin <jfhamlin@gmail.com>

Author: jfhamlin

pkg/lang/set.go

@@ -25,18 +25,26 @@ func CreatePersistentTreeSetWithComparator(comparator IFn, keys ISeq) interface{
 }
 
 func NewSet(vals ...interface{}) *Set {
+	set, err := NewSet2(vals...)
+	if err != nil {
+		panic(err)
+	}
+	return set
+}
+
+func NewSet2(vals ...interface{}) (*Set, error) {
 	// check for duplicates
 	for i := 0; i < len(vals); i++ {
 		for j := i + 1; j < len(vals); j++ {
 			if Equiv(vals[i], vals[j]) {
-				panic(NewIllegalArgumentError(fmt.Sprintf("duplicate key: %v", vals[i])))
+				return nil, NewIllegalArgumentError(fmt.Sprintf("duplicate key: %v", vals[i]))
 			}
 		}
 	}
 
 	return &Set{
 		vals: vals,
-	}
+	}, nil
 }
 
 var (

pkg/lang/symbol.go

@@ -2,6 +2,7 @@ package lang
 
 import (
 	"fmt"
+	"regexp"
 	"strings"
 )
 
@@ -11,6 +12,10 @@ type Symbol struct {
 	name string
 }
 
+var (
+	symbolRegex = regexp.MustCompile(`^(?:[^0-9/].*/)?(?:/|[^0-9/][^/]*)$`)
+)
+
 // NewSymbol creates a new symbol.
 func NewSymbol(s string) *Symbol {
 	ns, name := "", s
@@ -83,6 +88,9 @@ func isValidSymbol(ns, name string) bool {
 	} else {
 		full = ns + "/" + name
 	}
+	if !symbolRegex.MatchString(full) {
+		return false
+	}
 
 	// early special case for the division operator /
 	if full == "/" {
@@ -97,11 +105,11 @@ func isValidSymbol(ns, name string) bool {
 		// empty namespace
 		return false
 	}
-	if strings.HasSuffix(name, ":") {
+	if strings.HasSuffix(name, ":") || strings.HasSuffix(ns, ":") {
 		// name ends with a colon (match clojure)
 		return false
 	}
-	if strings.Contains(name, "::") {
+	if strings.Contains(full, "::") {
 		// name contains double colon
 		//
 		// NB: clojure reader rejects this, but clojure.core/symbol

pkg/reader/clj_conformance_test.go

@@ -66,6 +66,12 @@ func FuzzCLJConformance(f *testing.F) {
 		if err != nil {
 			f.Fatal(err)
 		}
+
+		// skip any files that contain the string ";; skip-clj"
+		if strings.Contains(string(data), ";; skip-clj") {
+			continue
+		}
+
 		f.Add(string(data))
 	}