Is it possible to set the file transfer status manually and signaling it via osdp_FTSTAT

[rherrmannr]

The current API does not allow the PD to change the status for a file transfer?
For example, if I want to signal a rebooting after a file transfer, I have no chance to do so as a PD?

From osdp_file.h

 * @param status File transfer status. This is a signed little- endian number
 *        -  0: ok to proceed
 *        -  1: file contents processed
 *        -  2: rebooting now, expect full communications reset
 *        -  3: PD is finishing file transfer. PD should send CMD_FILETRANSFER
 *              with data length set to 0 (idle) until this status changes
 *        - -1: abort file transfer
 *        - -2: unrecognized file contents
 *        - -3: file data unacceptable (malformed)

This would be nice, if my hw needs a reboot after a file has been received. Thus, I would like to set the state to 2 (rebooting).
An according event on the CP site for osdp_FTSTAT would be nice, too.

What's your opinion on this topic?

[sidcha]

Hi @rherrmannr, the idea sounds interesting. Do you want to create a PR with your proposed change?

[sidcha]

@rherrmannr in your last PR, you attempt to transparently forward the OSDP file transfer return codes. But what you really need is the end state or outcome of that transfer. So the events should be:

• File transfer OK
• File transfer OK, rebooting
• File transfer aborted
• Unrecognized file contents
• Invalid file contents

To get here, we need to refactor the file.c to pass through file transfer state machine and trigger the event from the end state.

[sidcha]

Commit f0990cd now address this.