From 6d14be2643e95b133e7635d280b826cfcb7f8cc0 Mon Sep 17 00:00:00 2001 From: blakeli Date: Fri, 3 Apr 2026 17:52:42 -0400 Subject: [PATCH 1/4] chore: Add style guide to gemini.md --- sdk-platform-java/GEMINI.md | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/sdk-platform-java/GEMINI.md b/sdk-platform-java/GEMINI.md index 6445163adfc3..b8dda2a7f41d 100644 --- a/sdk-platform-java/GEMINI.md +++ b/sdk-platform-java/GEMINI.md @@ -131,14 +131,21 @@ Showcase integration tests are run against a local server that implements the Sh cd java-showcase mvn verify -P enable-integration-tests ``` - -## 5. Dependency Management +## 5. Style Guide + +1. Minimize scope; avoid `public` unless necessary. +2. Use short names over fully qualified names. +3. Avoid `@ObsoleteApi` or `@Deprecated` methods unless necessary. +4. Avoid unnecessary formatting changes to keep diffs clean. +5. Use `mvn` for everything other than the `test/integration` folder. + +## 6. Dependency Management - Try not to bump any external dependency version unless there is a known CVE (security or vulnerability issue) or a critical bug fix. - Try to avoid introducing new external dependencies. If a new dependency is required, please state the reason. - Prefer to use features from the Java standard library, then try to use features from any existing dependencies (preferably from Google managed dependencies). -## 6. Contribution Guidelines +## 7. Contribution Guidelines - **Commits:** Commit messages should follow the [Conventional Commits](https://www.conventionalcommits.org/) specification. The format is `: `. The type should be one of the following: fix, feat, From e4e3ac7fb4a108c1e636451d37d98d193db2b017 Mon Sep 17 00:00:00 2001 From: Blake Li Date: Fri, 3 Apr 2026 18:19:53 -0400 Subject: [PATCH 2/4] Update sdk-platform-java/GEMINI.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- sdk-platform-java/GEMINI.md | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk-platform-java/GEMINI.md b/sdk-platform-java/GEMINI.md index b8dda2a7f41d..97bdc69cb66c 100644 --- a/sdk-platform-java/GEMINI.md +++ b/sdk-platform-java/GEMINI.md @@ -131,6 +131,7 @@ Showcase integration tests are run against a local server that implements the Sh cd java-showcase mvn verify -P enable-integration-tests ``` + ## 5. Style Guide 1. Minimize scope; avoid `public` unless necessary. From 97ecb4ecb25b71f90038e40d8446070a99334522 Mon Sep 17 00:00:00 2001 From: blakeli Date: Fri, 3 Apr 2026 18:21:14 -0400 Subject: [PATCH 3/4] chore: update --- sdk-platform-java/GEMINI.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-platform-java/GEMINI.md b/sdk-platform-java/GEMINI.md index 97bdc69cb66c..5f388c427b51 100644 --- a/sdk-platform-java/GEMINI.md +++ b/sdk-platform-java/GEMINI.md @@ -136,7 +136,7 @@ Showcase integration tests are run against a local server that implements the Sh 1. Minimize scope; avoid `public` unless necessary. 2. Use short names over fully qualified names. -3. Avoid `@ObsoleteApi` or `@Deprecated` methods unless necessary. +3. Avoid calling `@ObsoleteApi` or `@Deprecated` methods unless there are no alternatives. 4. Avoid unnecessary formatting changes to keep diffs clean. 5. Use `mvn` for everything other than the `test/integration` folder. From 7ca8499718c931b17cab170d39e4360efd57cdcd Mon Sep 17 00:00:00 2001 From: blakeli Date: Sat, 4 Apr 2026 00:25:41 -0400 Subject: [PATCH 4/4] chore: update --- sdk-platform-java/GEMINI.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-platform-java/GEMINI.md b/sdk-platform-java/GEMINI.md index 5f388c427b51..aed84e060b35 100644 --- a/sdk-platform-java/GEMINI.md +++ b/sdk-platform-java/GEMINI.md @@ -134,7 +134,7 @@ Showcase integration tests are run against a local server that implements the Sh ## 5. Style Guide -1. Minimize scope; avoid `public` unless necessary. +1. Minimize visibility scopes by defaulting to the most restrictive access level, avoiding the `public` modifier unless required. 2. Use short names over fully qualified names. 3. Avoid calling `@ObsoleteApi` or `@Deprecated` methods unless there are no alternatives. 4. Avoid unnecessary formatting changes to keep diffs clean.