Skip to content

fix(storage): fix flaky storage integration tests #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nidhiii-27 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −6
Draft

fix(storage): fix flaky storage integration tests #13256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afa3dda
fix(storage): fix flaky storage integration tests
nidhiii-27 May 22, 2026
5ed800c
refactor code
nidhiii-27 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions ...le-cloud-storage/src/test/java/com/google/cloud/storage/it/runner/registry/TestBench.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public void start() {
dockerImage,
"gunicorn",
"--bind=0.0.0.0:9000",
"--worker-class=sync",
"--worker-class=gthread",
"--threads=10",
"--access-logfile=-",
"--keep-alive=0",
Expand Down Expand Up @@ -401,6 +401,16 @@ private void dumpServerLog(String prefix, File out) throws IOException {
}
}

private static int findFreePort() {
try (java.net.ServerSocket socket = new java.net.ServerSocket()) {
socket.setReuseAddress(true);
socket.bind(new java.net.InetSocketAddress("127.0.0.1", 0));
return socket.getLocalPort();
} catch (java.io.IOException e) {
throw new RuntimeException("Failed to find a free port", e);
}
}
Comment thread
nidhiii-27 marked this conversation as resolved.

static Builder newBuilder() {
return new Builder();
}
Expand Down Expand Up @@ -442,8 +452,8 @@ public String toString() {
}

static final class Builder {
private static final String DEFAULT_BASE_URI = "http://localhost:9000";
private static final String DEFAULT_GRPC_BASE_URI = "http://localhost:9005";
private static final String DEFAULT_BASE_URI = "http://localhost";
private static final String DEFAULT_GRPC_BASE_URI = "http://localhost";
private static final String DEFAULT_IMAGE_NAME;
private static final String DEFAULT_IMAGE_TAG;

Expand Down Expand Up @@ -497,11 +507,11 @@ static final class Builder {
private Builder() {
this(
false,
DEFAULT_BASE_URI,
DEFAULT_GRPC_BASE_URI,
DEFAULT_BASE_URI + ":" + findFreePort(),
DEFAULT_GRPC_BASE_URI + ":" + findFreePort(),
DEFAULT_IMAGE_NAME,
DEFAULT_IMAGE_TAG,
DEFAULT_CONTAINER_NAME);
DEFAULT_CONTAINER_NAME + "_" + java.util.UUID.randomUUID().toString().substring(0, 8));
}
Comment thread
nidhiii-27 marked this conversation as resolved.

private Builder(
Expand Down
Loading